[mdatagen] support adding warnings to status table #20242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
requested review from
TylerHelmuth,
bogdandrutu,
evan-bradley and
dmitryax
as code owners
github-actions
bot
added
cmd/mdatagen
Foresight Summary
View More Details⭕ build-and-test-windows workflow has finished in 9 seconds (37 minutes 30 seconds less than
|
| Job | Failed Steps | Tests | |
|---|---|---|---|
| windows-unittest-matrix | - 🔗 | N/A | See Details |
| windows-unittest | - 🔗 | N/A | See Details |
✅ telemetrygen workflow has finished in 1 minute 10 seconds (32 seconds less than main branch avg.) and finished at 21st Mar, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| build-dev | - 🔗 | N/A | See Details |
| publish-latest | - 🔗 | N/A | See Details |
| publish-stable | - 🔗 | N/A | See Details |
✅ check-links workflow has finished in 1 minute 41 seconds and finished at 21st Mar, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changed files | - 🔗 | N/A | See Details |
| check-links | - 🔗 | N/A | See Details |
✅ changelog workflow has finished in 1 minute 53 seconds and finished at 21st Mar, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changelog | - 🔗 | N/A | See Details |
build-and-test workflow has finished in 9 minutes 40 seconds (43 minutes 16 seconds less than main branch avg.) and finished at 21st Mar, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| unittest-matrix (1.20, connector) | N/A | ✅ 126 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, connector) | N/A | ✅ 126 ❌ 0 ⏭ 0 🔗 | See Details |
| correctness-metrics | N/A | ✅ 2 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, internal) | N/A | ✅ 583 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, internal) | N/A | ✅ 583 ❌ 0 ⏭ 0 🔗 | See Details |
| correctness-traces | N/A | ✅ 17 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, processor) | N/A | ✅ 1557 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, extension) | N/A | ✅ 543 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, extension) | N/A | ✅ 543 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, processor) | N/A | ✅ 1557 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, receiver-0) | N/A | ✅ 2611 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, receiver-0) | N/A | ✅ 2611 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, exporter) | N/A | ✅ 2501 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, exporter) | N/A | ✅ 2501 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, receiver-1) | N/A | ✅ 1969 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, receiver-1) | N/A | ✅ 1969 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, other) | N/A | ✅ 4747 ❌ 0 ⏭ 0 🔗 | See Details |
| integration-tests | N/A | ✅ 55 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, other) | N/A | ✅ 4747 ❌ 0 ⏭ 0 🔗 | See Details |
✅ prometheus-compliance-tests workflow has finished in 3 minutes 45 seconds (3 minutes 10 seconds less than main branch avg.) and finished at 21st Mar, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| prometheus-compliance-tests | - 🔗 | ✅ 21 ❌ 0 ⏭ 0 🔗 | See Details |
✅ load-tests workflow has finished in 7 minutes 14 seconds (4 minutes 51 seconds less than main branch avg.) and finished at 21st Mar, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| loadtest (TestTraceAttributesProcessor) | - 🔗 | ✅ 3 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestIdleMode) | - 🔗 | ✅ 1 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | ✅ 6 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | ✅ 8 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | ✅ 18 ❌ 0 ⏭ 0 🔗 | See Details |
| setup-environment | - 🔗 | N/A | See Details |
✅ e2e-tests workflow has finished in 14 minutes 15 seconds and finished at 21st Mar, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| kubernetes-test (v1.26.0) | - 🔗 | N/A | See Details |
| kubernetes-test (v1.23.13) | - 🔗 | N/A | See Details |
| kubernetes-test (v1.24.7) | - 🔗 | N/A | See Details |
| kubernetes-test (v1.25.3) | - 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
codeboten
force-pushed
the
codeboten/mdatagen-warning
branch
from
4a7eb7e to
4112075
Compare
This change allows components to specify warnings in metadata.yaml. Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/mdatagen-warning
branch
from
4112075 to
b6e574c
Compare
atoulme
reviewed
Mar 21, 2023
|
This is nice :) |
atoulme
approved these changes
Mar 21, 2023
| @@ -7,10 +7,13 @@ | |||
| | Supported pipeline types | {{ stringsJoin .Status.Pipelines "," }} | | |||
There was a problem hiding this comment.
", "
Suggested change
| | Supported pipeline types | {{ stringsJoin .Status.Pipelines "," }} | | |
| | Supported pipeline types | {{ stringsJoin .Status.Pipelines ", " }} | |
There was a problem hiding this comment.
I'll commit this in a separate pr, as it changes many more readme's
dmitryax
reviewed
Mar 21, 2023
| @@ -254,6 +258,3 @@ The transform processor's implementation of the [OpenTelemetry Transformation La | |||
| - Although the OTTL allows the `set` function to be used with `metric.data_type`, its implementation in the transform processor is NOOP. To modify a data type you must use a function specific to that purpose. | |||
| - [Identity Conflict](https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/standard-warnings.md#identity-conflict): Transformation of metrics have the potential to affect the identity of a metric leading to an Identity Crisis. Be especially cautious when transforming metric name and when reducing/changing existing attributes. Adding new attributes is safe. | |||
| - [Orphaned Telemetry](https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/standard-warnings.md#orphaned-telemetry): The processor allows you to modify `span_id`, `trace_id`, and `parent_span_id` for traces and `span_id`, and `trace_id` logs. Modifying these fields could lead to orphaned spans or logs. | |||
There was a problem hiding this comment.
Should the links also be generated?
codeboten
pushed a commit
that referenced
this pull request
Mar 21, 2023
Follow up to #20242 --------- Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows components to specify warnings in metadata.yaml.