-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add F5 Cloud Exporter (1/3) #1965
Add F5 Cloud Exporter (1/3) #1965
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1965 +/- ##
==========================================
+ Coverage 89.15% 90.39% +1.23%
==========================================
Files 393 397 +4
Lines 19329 19469 +140
==========================================
+ Hits 17233 17599 +366
+ Misses 1641 1407 -234
- Partials 455 463 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@anuraaga - We may need to start looking into and resolve the linting issue with the
|
@anuraaga - Appears that the linting issue with |
Happy Wednesday/Thursday, @anuraaga! Hope your week is going well! Is there any possibility that you may be able to review this today or tomorrow? If not, do you have any recommendations on another reviewer that may be able to review the PR? |
@gramidt Sorry for missing this! My bad just seemed to be missing the notification, will check it out |
No worries at all, @anuraaga! I know you're busy and greatly appreciate all of your help. |
Signed-off-by: Granville Schmidt <[email protected]>
Signed-off-by: Granville Schmidt <[email protected]>
@anuraaga - Just updated with your current list of suggestions. Thank you again for all of your help! |
@bogdandrutu - I know you're super busy preparing for the workshop tomorrow, but if you get a moment, I would greatly appreciate your help with getting this merged. Thank you in advance for all of your help! |
Description:
Allow exporting of metric, trace, and log data to F5 Cloud
Link to tracking Issue:
#1964
Testing:
Unit tests are included
Documentation:
The documentation includes a short description and the configuration.
Notes:
awsprometheusremotewriteexporter
is implemented)