[receiver/windowsperfcounters] Returning partial errors for failures #16713

chrislbs · 2022-12-05T20:12:19Z

Returning partial errors for failure during scraping to prevent throwing out all succesfully retrieved metrics.

Description: Fixing a bug where a single instance of a windows performance object prevents metrics for all other valid instances from being published.

Link to tracking Issue: #16712

Testing: I added additional tests that verifies if some scrapers fail to retrieve metrics, the ones that don't fail continue to publish their metrics.

Documentation:

Returning partial errors for failure during scraping to prevent throwing out all succesfully retrieved metrics.

linux-foundation-easycla · 2022-12-05T20:12:22Z

The committers listed above are authorized under a signed CLA.

✅ login: chrislbs / name: Chris Pounds (d8647aa)

fatsheep9146 · 2022-12-06T05:58:16Z

@mx-psi can you approve this running workflow?

runforesight · 2022-12-07T09:31:04Z

Foresight Summary

Major Impacts

build-and-test-windows duration(24 minutes 51 seconds) has decreased 15 minutes 34 seconds compared to main branch avg(40 minutes 25 seconds).

View More Details

✅ check-links workflow has finished in 46 seconds (2 minutes 6 seconds less than `main` branch avg.) and finished at 7th Dec, 2022.

Job	Failed Steps	Tests
changed files	- 🔗	N/A	See Details
check-links	- 🔗	N/A	See Details

✅ tracegen workflow has finished in 1 minute 8 seconds (2 minutes 11 seconds less than `main` branch avg.) and finished at 7th Dec, 2022.

Job	Failed Steps	Tests
build-dev	- 🔗	N/A	See Details
publish-latest	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details

✅ prometheus-compliance-tests workflow has finished in 10 minutes 51 seconds (⚠️ 1 minute 45 seconds more than `main` branch avg.) and finished at 7th Dec, 2022.

Job	Failed Steps	Tests
prometheus-compliance-tests	- 🔗	✅ 21 ❌ 0 ⏭ 0 🔗	See Details

❌ build-and-test workflow has finished in 57 minutes 44 seconds and finished at 7th Dec, 2022. 1 job failed.

Job	Failed Steps	Tests
correctness-metrics	- 🔗	✅ 0 ❌ 0 ⏭ 0 🔗	See Details
correctness-traces	- 🔗	✅ 0 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, internal)	- 🔗	✅ 592 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, processor)	- 🔗	✅ 1466 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, internal)	- 🔗	✅ 592 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, extension)	- 🔗	✅ 528 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, extension)	- 🔗	✅ 528 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, processor)	- 🔗	✅ 1466 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, receiver-0)	- 🔗	✅ 2533 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-0)	- 🔗	✅ 2532 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, other)	- 🔗	✅ 4288 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, exporter)	- 🔗	✅ 2412 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, exporter)	- 🔗	✅ 2412 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, receiver-1)	- 🔗	✅ 1845 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-1)	- 🔗	✅ 1845 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, other)	- 🔗	✅ 4298 ❌ 0 ⏭ 0 🔗	See Details
integration-tests	- 🔗	✅ 59 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details
check-codeowners	- 🔗	N/A	See Details
check-collector-module-version	- 🔗	N/A	See Details
checks	Impi 🔗	N/A	See Details
build-examples	- 🔗	N/A	See Details
lint-matrix (receiver-0)	- 🔗	N/A	See Details
lint-matrix (receiver-1)	- 🔗	N/A	See Details
lint-matrix (processor)	- 🔗	N/A	See Details
lint-matrix (exporter)	- 🔗	N/A	See Details
lint-matrix (extension)	- 🔗	N/A	See Details
lint-matrix (internal)	- 🔗	N/A	See Details
lint-matrix (other)	- 🔗	N/A	See Details
lint	- 🔗	N/A	See Details
unittest (1.19)	- 🔗	N/A	See Details
unittest (1.18)	- 🔗	N/A	See Details
cross-compile (darwin, amd64)	- 🔗	N/A	See Details
cross-compile (darwin, arm64)	- 🔗	N/A	See Details
cross-compile (linux, 386)	- 🔗	N/A	See Details
cross-compile (linux, amd64)	- 🔗	N/A	See Details
cross-compile (linux, arm)	- 🔗	N/A	See Details
cross-compile (linux, arm64)	- 🔗	N/A	See Details
cross-compile (linux, ppc64le)	- 🔗	N/A	See Details
cross-compile (windows, 386)	- 🔗	N/A	See Details
cross-compile (windows, amd64)	- 🔗	N/A	See Details
build-package (deb)	- 🔗	N/A	See Details
build-package (rpm)	- 🔗	N/A	See Details
windows-msi	- 🔗	N/A	See Details
publish-check	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details
publish-dev	- 🔗	N/A	See Details

✅ load-tests workflow has finished in 17 minutes 7 seconds and finished at 7th Dec, 2022.

Job	Failed Steps	Tests
loadtest (TestIdleMode)	- 🔗	✅ 1 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceAttributesProcessor)	- 🔗	✅ 3 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetric10kDPS\|TestMetricsFromFile)	- 🔗	✅ 6 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceNoBackend10kSPS\|TestTrace1kSPSWithAttrs)	- 🔗	✅ 8 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceBallast1kSPSWithAttrs\|TestTraceBallast1kSPSAddAttrs)	- 🔗	✅ 10 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetricResourceProcessor\|TestTrace10kSPS)	- 🔗	✅ 12 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestBallastMemory\|TestLog10kDPS)	- 🔗	✅ 19 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details

❌ changelog workflow has finished in 47 seconds (1 minute 17 seconds less than `main` branch avg.) and finished at 27th Jan, 2023. 1 job failed.

Job	Failed Steps	Tests
changelog	Ensure ./.chloggen/*.yaml addition(s) 🔗	N/A	See Details

❌ build-and-test-windows workflow has finished in 24 minutes 51 seconds (15 minutes 34 seconds less than `main` branch avg.) and finished at 27th Jan, 2023. 1 job failed.

Job	Failed Steps	Tests
windows-unittest-matrix (extension)	- 🔗	✅ 534 ❌ 0 ⏭ 0 🔗	See Details
windows-unittest-matrix (internal)	- 🔗	✅ 525 ❌ 0 ⏭ 0 🔗	See Details
windows-unittest-matrix (processor)	- 🔗	✅ 1471 ❌ 0 ⏭ 0 🔗	See Details
windows-unittest-matrix (receiver-1)	Run Unit tests 🔗	✅ 1348 ❌ 0 ⏭ 0 🔗	See Details
windows-unittest-matrix (other)	- 🔗	✅ 36 ❌ 0 ⏭ 0 🔗	See Details
windows-unittest-matrix (receiver-0)	- 🔗	✅ 2397 ❌ 0 ⏭ 0 🔗	See Details
windows-unittest-matrix (exporter)	- 🔗	✅ 804 ❌ 0 ⏭ 0 🔗	See Details
windows-unittest	- 🔗	N/A	See Details

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

fatsheep9146 · 2022-12-07T10:51:38Z

The changelog should be added. @chrislbs

chrislbs · 2022-12-07T17:01:33Z

I'll get the changelog entry done today.

github-actions · 2022-12-22T05:17:19Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

fatsheep9146 · 2022-12-22T05:19:07Z

@chrislbs any progress?

github-actions · 2023-01-06T05:17:30Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions · 2023-01-26T05:17:36Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

dmitryax · 2023-01-26T22:47:23Z

receiver/windowsperfcountersreceiver/windowsperfcounters_scraper.go

@@ -19,6 +19,7 @@ package windowsperfcountersreceiver // import "github.com/open-telemetry/opentel

 import (
 	"context"
+	"go.opentelemetry.io/collector/receiver/scrapererror"


Please move this import to the second group. This should solve the linter errors. Same in the test file

dmitryax · 2023-01-26T22:48:55Z

And please rebase

fatsheep9146 · 2023-02-06T13:26:23Z

ping @chrislbs

github-actions · 2023-05-26T22:01:30Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions · 2023-06-11T05:18:52Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions · 2023-06-26T05:20:04Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions · 2023-07-10T05:20:15Z

Closed as inactive. Feel free to reopen if this PR is still being worked on.

bartecargo · 2024-03-25T18:10:37Z

This is sorely needed for Windows users.

chrislbs · 2024-04-15T15:23:33Z

I opened an updated PR with the changes here. #32370

[receiver/windowsperfcounters] Returning partial errors for failures

d8647aa

Returning partial errors for failure during scraping to prevent throwing out all succesfully retrieved metrics.

chrislbs requested a review from a team December 5, 2022 20:12

chrislbs requested a review from dashpole as a code owner December 5, 2022 20:12

github-actions bot assigned dmitryax Dec 5, 2022

github-actions bot added the receiver/windowsperfcounters label Dec 5, 2022

github-actions bot added the Stale label Dec 22, 2022

github-actions bot removed the Stale label Dec 23, 2022

github-actions bot added the Stale label Jan 6, 2023

mx-psi removed the Stale label Jan 10, 2023

dmitryax added the Run Windows Enable running windows test on a PR label Jan 12, 2023

github-actions bot added the Stale label Jan 26, 2023

dmitryax reviewed Jan 26, 2023

View reviewed changes

fatsheep9146 removed the Stale label Jan 27, 2023

github-actions bot added the Stale label May 26, 2023

fatsheep9146 removed the Stale label May 27, 2023

github-actions bot added the Stale label Jun 11, 2023

fatsheep9146 removed the Stale label Jun 11, 2023

github-actions bot added the Stale label Jun 26, 2023

github-actions bot closed this Jul 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[receiver/windowsperfcounters] Returning partial errors for failures #16713

[receiver/windowsperfcounters] Returning partial errors for failures #16713

chrislbs commented Dec 5, 2022

linux-foundation-easycla bot commented Dec 5, 2022 •

edited

Loading

fatsheep9146 commented Dec 6, 2022

runforesight bot commented Dec 7, 2022 •

edited

Loading

`build-and-test-windows` duration(24 minutes 51 seconds) has decreased 15 minutes 34 seconds compared to main branch avg(40 minutes 25 seconds).

✅ check-links workflow has finished in 46 seconds (2 minutes 6 seconds less than `main` branch avg.) and finished at 7th Dec, 2022.

✅ tracegen workflow has finished in 1 minute 8 seconds (2 minutes 11 seconds less than `main` branch avg.) and finished at 7th Dec, 2022.

✅ prometheus-compliance-tests workflow has finished in 10 minutes 51 seconds (⚠️ 1 minute 45 seconds more than `main` branch avg.) and finished at 7th Dec, 2022.

❌ build-and-test workflow has finished in 57 minutes 44 seconds and finished at 7th Dec, 2022. 1 job failed.

✅ load-tests workflow has finished in 17 minutes 7 seconds and finished at 7th Dec, 2022.

❌ changelog workflow has finished in 47 seconds (1 minute 17 seconds less than `main` branch avg.) and finished at 27th Jan, 2023. 1 job failed.

❌ build-and-test-windows workflow has finished in 24 minutes 51 seconds (15 minutes 34 seconds less than `main` branch avg.) and finished at 27th Jan, 2023. 1 job failed.

fatsheep9146 commented Dec 7, 2022

chrislbs commented Dec 7, 2022

github-actions bot commented Dec 22, 2022

fatsheep9146 commented Dec 22, 2022

github-actions bot commented Jan 6, 2023

github-actions bot commented Jan 26, 2023

dmitryax Jan 26, 2023

dmitryax commented Jan 26, 2023

fatsheep9146 commented Feb 6, 2023

github-actions bot commented May 26, 2023

github-actions bot commented Jun 11, 2023

github-actions bot commented Jun 26, 2023

github-actions bot commented Jul 10, 2023

bartecargo commented Mar 25, 2024

chrislbs commented Apr 15, 2024

[receiver/windowsperfcounters] Returning partial errors for failures #16713

[receiver/windowsperfcounters] Returning partial errors for failures #16713

Conversation

chrislbs commented Dec 5, 2022

linux-foundation-easycla bot commented Dec 5, 2022 • edited Loading

fatsheep9146 commented Dec 6, 2022

runforesight bot commented Dec 7, 2022 • edited Loading

Foresight Summary

build-and-test-windows duration(24 minutes 51 seconds) has decreased 15 minutes 34 seconds compared to main branch avg(40 minutes 25 seconds).

✅ check-links workflow has finished in 46 seconds (2 minutes 6 seconds less than main branch avg.) and finished at 7th Dec, 2022.

✅ tracegen workflow has finished in 1 minute 8 seconds (2 minutes 11 seconds less than main branch avg.) and finished at 7th Dec, 2022.

✅ prometheus-compliance-tests workflow has finished in 10 minutes 51 seconds (⚠️ 1 minute 45 seconds more than main branch avg.) and finished at 7th Dec, 2022.

❌ build-and-test workflow has finished in 57 minutes 44 seconds and finished at 7th Dec, 2022. 1 job failed.

✅ load-tests workflow has finished in 17 minutes 7 seconds and finished at 7th Dec, 2022.

❌ changelog workflow has finished in 47 seconds (1 minute 17 seconds less than main branch avg.) and finished at 27th Jan, 2023. 1 job failed.

❌ build-and-test-windows workflow has finished in 24 minutes 51 seconds (15 minutes 34 seconds less than main branch avg.) and finished at 27th Jan, 2023. 1 job failed.

fatsheep9146 commented Dec 7, 2022

chrislbs commented Dec 7, 2022

github-actions bot commented Dec 22, 2022

fatsheep9146 commented Dec 22, 2022

github-actions bot commented Jan 6, 2023

github-actions bot commented Jan 26, 2023

dmitryax Jan 26, 2023

Choose a reason for hiding this comment

dmitryax commented Jan 26, 2023

fatsheep9146 commented Feb 6, 2023

github-actions bot commented May 26, 2023

github-actions bot commented Jun 11, 2023

github-actions bot commented Jun 26, 2023

github-actions bot commented Jul 10, 2023

bartecargo commented Mar 25, 2024

chrislbs commented Apr 15, 2024

linux-foundation-easycla bot commented Dec 5, 2022 •

edited

Loading

runforesight bot commented Dec 7, 2022 •

edited

Loading

`build-and-test-windows` duration(24 minutes 51 seconds) has decreased 15 minutes 34 seconds compared to main branch avg(40 minutes 25 seconds).

✅ check-links workflow has finished in 46 seconds (2 minutes 6 seconds less than `main` branch avg.) and finished at 7th Dec, 2022.

✅ tracegen workflow has finished in 1 minute 8 seconds (2 minutes 11 seconds less than `main` branch avg.) and finished at 7th Dec, 2022.

✅ prometheus-compliance-tests workflow has finished in 10 minutes 51 seconds (⚠️ 1 minute 45 seconds more than `main` branch avg.) and finished at 7th Dec, 2022.

❌ changelog workflow has finished in 47 seconds (1 minute 17 seconds less than `main` branch avg.) and finished at 27th Jan, 2023. 1 job failed.

❌ build-and-test-windows workflow has finished in 24 minutes 51 seconds (15 minutes 34 seconds less than `main` branch avg.) and finished at 27th Jan, 2023. 1 job failed.