Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/oracledbreceiver] Add oracledb metrics #14913

Merged
merged 9 commits into from
Oct 15, 2022

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 12, 2022

Description:
Adds the metadata.yaml file describing the metrics scraped by the OracleDB receiver, along with generated content.

Link to tracking Issue:
#13939

Testing:
None - just adding the metrics

Documentation:
Generated docs.

@atoulme atoulme requested a review from a team October 12, 2022 23:04
@atoulme atoulme requested a review from dmitryax as a code owner October 12, 2022 23:04
@atoulme atoulme changed the title Add oracledb metrics [receiver/oracledbreceiver] Add oracledb metrics Oct 13, 2022
receiver/oracledbreceiver/documentation.md Outdated Show resolved Hide resolved
receiver/oracledbreceiver/documentation.md Outdated Show resolved Hide resolved
receiver/oracledbreceiver/documentation.md Outdated Show resolved Hide resolved
receiver/oracledbreceiver/documentation.md Outdated Show resolved Hide resolved
@atoulme atoulme force-pushed the add_oracledb_metrics branch from cf42901 to 56d3dc4 Compare October 14, 2022 17:00
@atoulme atoulme force-pushed the add_oracledb_metrics branch from 56d3dc4 to 2a4c1ca Compare October 14, 2022 17:01
receiver/oracledbreceiver/documentation.md Outdated Show resolved Hide resolved
receiver/oracledbreceiver/documentation.md Outdated Show resolved Hide resolved
receiver/oracledbreceiver/documentation.md Outdated Show resolved Hide resolved
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of last comments, otherwise LGTM

receiver/oracledbreceiver/documentation.md Outdated Show resolved Hide resolved
receiver/oracledbreceiver/documentation.md Outdated Show resolved Hide resolved
receiver/oracledbreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/oracledbreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/oracledbreceiver/metadata.yaml Outdated Show resolved Hide resolved
@dmitryax dmitryax merged commit 97c4503 into open-telemetry:main Oct 15, 2022
@atoulme atoulme deleted the add_oracledb_metrics branch October 15, 2022 00:46
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants