-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/oracledbreceiver] New oracle DB receiver #14316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
new_oracle_receiver
branch
7 times, most recently
from
September 20, 2022 06:35
26e312c
to
64cb734
Compare
@dmitryax to review as a CODEOWNER |
atoulme
force-pushed
the
new_oracle_receiver
branch
from
September 27, 2022 00:30
64cb734
to
a7e55eb
Compare
atoulme
changed the title
WIP - new oracle DB receiver
[receiver/oracledbreceiver] New oracle DB receiver
Sep 27, 2022
atoulme
force-pushed
the
new_oracle_receiver
branch
2 times, most recently
from
September 27, 2022 17:18
4cc767a
to
54c9dbf
Compare
atoulme
force-pushed
the
new_oracle_receiver
branch
from
September 30, 2022 19:22
54c9dbf
to
dbacce2
Compare
atoulme
force-pushed
the
new_oracle_receiver
branch
from
September 30, 2022 23:08
56e8155
to
1b48fdc
Compare
dmitryax
approved these changes
Oct 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a docs nit
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
New Oracle DB receiver component
Link to tracking Issue:
#13939
Testing:
Simple functional testing as with other components
Documentation:
Metrics generated with
metadata.yaml
.