[receiver/solacereceiver] Added publish topic as attribute on propagated spans #12640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@mcardy, I seem to have missed this one. It looks like you'll need to rebase in order to pick up some CI fixes. |
|
@djaglowski I've rebased. I noticed that the changelog job failed since I don't have an associated issue. Should I just open an issue describing the enhancement? |
|
@mcardy, you can use the PR # instead. |
djaglowski
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added a new attribute
messaging.destinationto the receiver's propagated tracesLink to tracking Issue: None
Testing: Unit tests updated
Documentation: No required changes
@djaglowski FYI 😄