Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/transformprocessor/internal/traces] Enable gocritic #12508

Closed
wants to merge 3 commits into from
Closed

[processor/transformprocessor/internal/traces] Enable gocritic #12508

wants to merge 3 commits into from

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Jul 16, 2022

Enable gocritic in processor/transformprocessor/internal/traces

part of issue: #10466

@my-git9 my-git9 requested a review from a team July 16, 2022 05:24
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 18, 2022
codeboten
codeboten reviewed Jul 19, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt look like this is enabling gocritic, does line 15 need to be removed?

@TylerHelmuth
Copy link
Member

I'd prefer to see this implemented in pkg/telemetryquerylanguage once #12589 is merged. While we extract packages we are trying not to change the transform processor.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 5, 2022
@my-git9 my-git9 closed this Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

Assignees

@dashpole dashpole

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@my-git9 @TylerHelmuth @codeboten @dashpole @mx-psi @fatsheep9146