[exporter/datadog] Remove Docker hostname detector #11834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSerrania
approved these changes
Jun 30, 2022
mx-psi
added
the
ready to merge
codeboten
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove
dockerhostname detector. The detector does not work on the official opentelemetry-collector-contrib Docker images (because of the same reasons described in #11791), and there is an alternative setup (using--hostname), so it's better to just remove it.This could be a breaking change for users of downstream distros (or custom builds) that don't set the user as non-root in their Docker image, but since this is behind an alpha feature gate it is okay to remove it in one release.