modify simpleprometheus receiver to use httpclientsetting

[fatsheep9146]

Signed-off-by: Ziqi Zhao [email protected]

Description:
Fix #9571

Link to tracking Issue:
#9571

[fatsheep9146]

ping @codeboten @dmitryax , I already modify the simpleprometheusreceiver to use confighttp.HttpClientSetting, but there is still one problem that I'm not sure, since the origin tls config of simpleprometheusreceiver has totally different key name from the tls config of confighttp.HttpClientSetting.

for example, the tls config of simpleprometheusreceiver is

        endpoint: "172.17.0.5:9153"
        tls_enabled: true
        tls_config:
            ca_file: "/path/to/ca"
            cert_file: "/path/to/cert"
            key_file: "/path/to/key"
            insecure_skip_verify: true

the tls config of confighttp.HttpClientSetting is

    endpoint: myserver.local:55690
    tls:
      insecure: false
      ca_file: server.crt
      cert_file: client.crt
      key_file: client.key

What is the best way to release those changes safely? Does this have any guideline like https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#breaking-changes?

[dmitryax]

Please keep support of tls_config as a deprecated option for now and show a warning log if it's being used. It can be removed later

[fatsheep9146]

Please keep support of tls_config as a deprecated option for now and show a warning log if it's being used. It can be removed later
@dmitryax

I add tls_config , tls_enable back to configuration, add a new function getPrometheusConfigWrapper in the basic of getPrometheusConfig.

If user specify tls_enable , I print a warning log and use the info in tls_config to create httpClientSetting config then pass to getPrometheusConfig.

In this way, I think we can just delete tls_enable, tls_config field, function getPrometheusConfigWrapper and use getPrometheusConfig directly.

[dmitryax]

Please add a changelog entry

[dmitryax]

One nit, otherwise LGTM

[fatsheep9146]

ping @codeboten @dmitryax I think pr is ready to merge :-)

[dmitryax]

Did you test the receiver? I doesn't look like working for regular http endpoints