[receiver/sqlquery] add basic functionality #10867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
reviewed
Jun 10, 2022
rmfitzpatrick
approved these changes
Jun 15, 2022
crobert-1
approved these changes
Jun 15, 2022
crobert-1
reviewed
Jun 23, 2022
crobert-1
requested changes
Jun 23, 2022
crobert-1
approved these changes
Jun 23, 2022
|
Resolves feature request: #10544 |
Konig-Corey
reviewed
Jun 24, 2022
dmitryax
reviewed
Jun 28, 2022
|
@pmcollins Created a PR against your branch that includes requested changes from @dmitryax as well as discussed tags addition. https://github.com/pmcollins/opentelemetry-collector-contrib/pull/2805 |
|
@Konig-Corey I believe you can push commits right into |
…rt for bad configs
…ultierr on Scrape
I had tried that originally and didn't let me. I doubt it would be set to public access so I just created a PR. If he approves it it should just update this PR since its on the source branch of this PR. Am I missing something? |
|
I'm not sure, I worked for me every time I tried. |
Use 'float' instead of 'double' in config. Disallow explicit aggregation when data type is gauge.
dmitryax
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR for the new sqlquery receiver, containing the receiver's functionality, but without enabling the component.
First PR is here: #9407