Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Queuing, retry and timeout settings to AWS S3 exporter #36264

Open
stephenhong opened this issue Nov 7, 2024 · 6 comments
Open

Add Queuing, retry and timeout settings to AWS S3 exporter #36264

stephenhong opened this issue Nov 7, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request exporter/awss3

Comments

@stephenhong
Copy link

Component(s)

exporter/awss3

Is your feature request related to a problem? Please describe.

There is no configuration option for queuing, retry and timeout for the AWS S3 exporter. I see that the exporterhelper is part of the factory.go but when I tried to use the options in my config.yaml, the collector wouldn't start

Describe the solution you'd like

I believe adding it in the config.go like this would add the options available

Describe alternatives you've considered

No response

Additional context

If the queuing, retry and timeout settings were left out intentionally, may I ask why they had to be taken out?

@stephenhong stephenhong added enhancement New feature or request needs triage New item requiring triage labels Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme
Copy link
Contributor

atoulme commented Nov 10, 2024

Sounds good.

@atoulme atoulme removed the needs triage New item requiring triage label Nov 10, 2024
@VihasMakwana
Copy link
Contributor

@stephenhong I can work on this, unless you're planning to implement it. Let me know!

@stephenhong
Copy link
Author

@stephenhong I can work on this, unless you're planning to implement it. Let me know!

Yes, please do. Thank you

@VihasMakwana VihasMakwana self-assigned this Nov 13, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@lopes-felipe
Copy link
Member

Queueing implemented here:
#37274

@github-actions github-actions bot removed the Stale label Jan 17, 2025
songy23 pushed a commit that referenced this issue Jan 17, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Implements the common queueing feature into the `awss3exporter`, as
suggested
[here](#36264).
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this issue Jan 26, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Implements the common queueing feature into the `awss3exporter`, as
suggested
[here](open-telemetry#36264).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter/awss3
Projects
None yet
Development

No branches or pull requests

4 participants