Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIS Application Pool metrics #34924

Open
syron opened this issue Aug 29, 2024 · 13 comments
Open

IIS Application Pool metrics #34924

syron opened this issue Aug 29, 2024 · 13 comments
Assignees
Labels

Comments

@syron
Copy link
Contributor

syron commented Aug 29, 2024

Component(s)

receiver/iis

Is your feature request related to a problem? Please describe.

An application pool can be stopped or started. Sometimes, due to password changes and server restarts, the application pools can not be started and is therefore stopped.

Describe the solution you'd like

It would be great to get a list of all available application pools while also scraping the performance counters and for each and every one of them, the state (whether they are running or not).

An application pool can have the following states:

State Id Description
Started 1 The Site, ApplicationPool, or WorkerProcess object has started.
Starting 0 The object is in the process of starting.
Stopped 3 The object has stopped.
Stopping 2 The object is in the process of stopping.
Unknown 4 The object is in an unknown state.

(Source: https://learn.microsoft.com/en-us/dotnet/api/microsoft.web.administration.objectstate?view=iis-dotnet)

Describe alternatives you've considered

Developing a windows exporter in dotnet that runs as a Windows service providing the data to the otel collector.

Additional context

No response

@syron syron added enhancement New feature or request needs triage New item requiring triage labels Aug 29, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@pjanotti
Copy link
Contributor

pjanotti commented Aug 30, 2024

This is effectively a proposal to add a metric mapping the APP_POOL_WAS(*)\Current Application Pool State performance counter.

@pjanotti
Copy link
Contributor

/label os:windows

@crobert-1
Copy link
Member

Removing needs triage based on code owner response that this is a valid enhancement request.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Sep 4, 2024
@syron
Copy link
Contributor Author

syron commented Oct 3, 2024

Would it be possible for me to start to work on this? I don't know the procedure here, but as I have read I am supposed to comment the ticket so it could potentially be assigned to me?

@crobert-1
Copy link
Member

Hello @syron, thanks for being willing to help out here! It doesn't look like anyone else has picked up this work yet, so you're welcome to work on it 👍

@syron
Copy link
Contributor Author

syron commented Oct 23, 2024

Sorry for the late response. Awesome, thanks @crobert-1 I will start working on it.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Dec 23, 2024
@pjanotti
Copy link
Contributor

pjanotti commented Jan 6, 2025

Hi @syron, are you still planning to work on this issue?

@github-actions github-actions bot removed the Stale label Jan 7, 2025
@syron
Copy link
Contributor Author

syron commented Feb 3, 2025

Hi @syron, are you still planning to work on this issue?

Hi @pjanotti! Yes, I am planning to work on this. I had to repriotize unfortunately, but now I am back on track.

@syron
Copy link
Contributor Author

syron commented Feb 25, 2025

I have added a pull request for this. However, I need to go through some of the formalia. #38183

songy23 pushed a commit that referenced this issue Feb 27, 2025
…38183)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Added new metrics

* application pool state: Each application pool's state
* application pool uptime: The number of milliseconds an application
pool has been up.

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
#34924 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Has been tested on a local windows machine.

<!--Describe the documentation added.-->
#### Documentation

Metadata documention has been updated by mdatagen.

<!--Please delete paragraphs that you did not use before submitting.-->
@syron
Copy link
Contributor Author

syron commented Mar 3, 2025

One question that came to my mind. The metrics that have been merged are marked as enabled = false and one of the comments by @atoulme was to create a new PR with enabled = true and mark it as breaking change. In order for this issue to be closed, should a new PR be created for this or should a new issue be raised and this one closed?

@atoulme
Copy link
Contributor

atoulme commented Mar 3, 2025

Start with a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants