Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insecure_skip_verify=true is not working while sending trace data in datadog exporter #22772

Closed
sreejithav opened this issue May 25, 2023 · 2 comments · Fixed by #22779
Closed
Assignees
Labels
bug Something isn't working exporter/datadog Datadog components

Comments

@sreejithav
Copy link

sreejithav commented May 25, 2023

Component(s)

exporter/datadog

What happened?

Description

i am getting this error even if i set insecure_skip_verify=true ... "debug [email protected]/zaplogger.go:39 Retrying to flush trace payload; error: Post "https://trace.agent.us5.datadoghq.com/api/v0.2/traces": x509: certificate signed by unknown authority {"kind": "exporter", "data_type": "metrics", "name": "datadog"} . looks like insecure_skip_verify works only for logs not for traces.

Steps to Reproduce

I am using opentelemetry demo apps and using Datadog exporter.
opentelemetricSDK --> collector--> datadog

Expected Result

if i set insecure_skip_verify=true , it should skip certificate validation.

Actual Result

if i set insecure_skip_verify=true , it is skipping certificate validation for logs and metrics but not for traces.

Collector version

latest

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

receivers:
hostmetrics:
collection_interval: 10s
scrapers:
paging:
metrics:
system.paging.utilization:
enabled: true
cpu:
metrics:
system.cpu.utilization:
enabled: true
disk:
filesystem:
metrics:
system.filesystem.utilization:
enabled: true
load:
memory:
network:
processes:
otlp:
protocols:
grpc:
http:
cors:
allowed_origins:
- "http://"
- "https://
"
exporters:
otlp:
endpoint: "jaeger:4317"
tls:
insecure: false
ca_file: /etc/ssl/certs/cert.pem
logging:
prometheus:
endpoint: "otelcol:9464"
resource_to_telemetry_conversion:
enabled: true
enable_open_metrics: true
datadog:
api:
site: "us5.datadoghq.com"
key: "XXXX"
tls:
insecure_skip_verify: true
processors:
batch:
spanmetrics:
metrics_exporter: prometheus
transform:
metric_statements:
- context: metric
statements:
- set(description, "Measures the duration of inbound HTTP requests") where name == "http.server.duration"
filter:
metrics:
exclude:
match_type: strict
metric_names:
- queueSize
service:
pipelines:
traces:
receivers: [otlp]
processors: [spanmetrics, batch]
exporters: [otlp, logging, datadog]
metrics:
receivers: [otlp]
processors: [filter, transform, batch]
exporters: [prometheus, logging, datadog]
logs:
receivers: [otlp]
processors: [batch]
exporters: [logging, datadog]

Log output

No response

Additional context

No response

@sreejithav sreejithav added bug Something isn't working needs triage New item requiring triage labels May 25, 2023
@github-actions github-actions bot added the exporter/datadog Datadog components label May 25, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@gbbr
Copy link
Member

gbbr commented May 25, 2023

Hi there! Thanks for flagging. Indeed you are right, this is a bug. I opened a PR (#22779) to fix it.

@songy23 songy23 removed the needs triage New item requiring triage label May 25, 2023
codeboten pushed a commit that referenced this issue May 25, 2023
Fixes #22772

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Yang Song <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exporter/datadog Datadog components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants