Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Kinesis exporter to awskinesisexporter #2164

Closed
rakyll opened this issue Jan 21, 2021 · 1 comment
Closed

Rename Kinesis exporter to awskinesisexporter #2164

rakyll opened this issue Jan 21, 2021 · 1 comment
Assignees
@alolita
Labels
priority:p2 Medium release:allowed-for-ga spec:logs spec:metrics spec:trace

Comments

@rakyll
Copy link
Contributor

rakyll commented Jan 21, 2021

In order to have consistency with other Amazon/AWS exporters, move the kinesisexporter into awskinesisexporter.

The official name for Kinesis is Amazon Kinesis, but we named Amazon Managed Service for Prometheus exporter as "awsprometheusremotewriteexporter". For consistency, I think it's ok to use "aws" as a prefix.
@bogdandrutu
Copy link
Member

I think it is ok because Kinesis is an AWS product only :)

dyladan referenced this issue in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
@dependabot
Bump github.com/jaegertracing/jaeger from 1.20.0 to 1.21.0 (#2164)
f583f6e 
Bumps [github.com/jaegertracing/jaeger](https://github.com/jaegertracing/jaeger) from 1.20.0 to 1.21.0.
- [Release notes](https://github.com/jaegertracing/jaeger/releases)
- [Changelog](https://github.com/jaegertracing/jaeger/blob/master/CHANGELOG.md)
- [Commits](jaegertracing/jaeger@v1.20.0...v1.21.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
flands added a commit to flands/opentelemetry-collector-contrib that referenced this issue Feb 1, 2021
@flands
BREAKING CHANGE: Rename kinesis exporter to awskinesis
4e8b510 
Addresses open-telemetry#2164
@flands flands mentioned this issue Feb 1, 2021
Merged
bogdandrutu pushed a commit that referenced this issue Feb 2, 2021
@flands
BREAKING CHANGE: Rename kinesis exporter to awskinesis (#2234)
9677f5b 
* BREAKING CHANGE: Rename kinesis exporter to awskinesis

Addresses #2164

* Fix lint
@flands flands closed this as completed Feb 2, 2021
pmatyjasek-sumo referenced this issue in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
@flands @pmatyjasek-sumo
BREAKING CHANGE: Rename kinesis exporter to awskinesis (#2234)
7e476a5 
* BREAKING CHANGE: Rename kinesis exporter to awskinesis

Addresses #2164

* Fix lint
ljmsc referenced this issue in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
@MrAlias
Add OC bridge internal unit tests (#2164)
89a9489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alolita alolita

Labels
priority:p2 Medium release:allowed-for-ga spec:logs spec:metrics spec:trace
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@andrewhsu @rakyll @flands @bogdandrutu @alolita