Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change componets config tests to use confmaptest #13224

Closed
4 tasks done
bogdandrutu opened this issue Aug 11, 2022 · 9 comments
Closed
4 tasks done

Change componets config tests to use confmaptest #13224

bogdandrutu opened this issue Aug 11, 2022 · 9 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bogdandrutu
Copy link
Member

bogdandrutu commented Aug 11, 2022 •
edited
Loading

An example from core can be found here open-telemetry/opentelemetry-collector#5895

  • Change receivers
  • Change processors
  • Change exporters
  • Change extensions
@bogdandrutu bogdandrutu mentioned this issue Aug 11, 2022
Merged
@kovrus
Copy link
Member

kovrus commented Aug 12, 2022

@bogdandrutu can I take over Change processors?

@bogdandrutu
Copy link
Member Author

Go for it, see the new PR I merge, I feel that model is easier to use than what I did in core.

@dmitryax dmitryax added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 12, 2022
@kovrus kovrus mentioned this issue Aug 12, 2022
Merged
6 tasks
kovrus added a commit to kovrus/opentelemetry-collector-contrib that referenced this issue Aug 15, 2022
@kovrus
[chore] change processor config tests to unmarshal the config for tha…
c3cf057 
…t component

Updates open-telemetry#13224

- attributesprocessor
- cumulativetodeltaprocessor
- deltatorateprocessor
- filterprocessor
- groupbyattrsprocessor
- groupbytraceprocessor
This was referenced Aug 15, 2022
Merged
Merged
kovrus added a commit to kovrus/opentelemetry-collector-contrib that referenced this issue Aug 15, 2022
@kovrus
[chore] change processor config tests to unmarshal config only for th…
373a57e 
…at component.

Updates open-telemetry#13224

- attributesprocessor
- cumulativetodeltaprocessor
- deltatorateprocessor
- filterprocessor
- groupbyattrsprocessor
- groupbytraceprocessor
bogdandrutu pushed a commit that referenced this issue Aug 15, 2022
@kovrus
[chore] Change processor config tests to unmarshal config only for th…
038c562 
…at component. (part 1) (#13298)

* [chore] change processor config tests to unmarshal config only for that component.

Updates #13224

- attributesprocessor
- cumulativetodeltaprocessor
- deltatorateprocessor
- filterprocessor
- groupbyattrsprocessor
- groupbytraceprocessor

* [chore] Address comments.

* [chore] run "make gotidy"

build-and-test / checks (pull_request) Failing after 3m — checks

Following instructions:
```
go.mod/go.sum deps changes detected, please run "make gotidy" and commit the changes in this PR.
```
@kovrus kovrus mentioned this issue Aug 16, 2022
Merged
20 tasks
@kovrus kovrus mentioned this issue Aug 25, 2022
Merged
@bogdandrutu
Copy link
Member Author

@kovrus do you want to do the exporters as well?

@kovrus
Copy link
Member

kovrus commented Sep 20, 2022 •
edited
Loading

@bogdandrutu can do that sometime this week. BTW processors are not finished yet. So I'll probably finish them first.

This was referenced Sep 26, 2022
Merged
Merged
Merged
Merged
@kovrus
Copy link
Member

kovrus commented Sep 28, 2022 •
edited
Loading

receivers left:

  • dockerstatsreceiver
  • receivercreator
  • expvarreceiver
  • googlecloudpubsubreceiver
  • googlecloudspannerreceiver
  • prometheusreceiver
  • windowseventlogreceiver

edit: #14704

@bogdandrutu
Copy link
Member Author

@kovrus thanks for the progress. Let me know if there is anything I can do to help.

@kovrus kovrus mentioned this issue Oct 4, 2022
Merged
7 tasks
This was referenced Oct 6, 2022
Merged
Merged
@kovrus
Copy link
Member

kovrus commented Oct 7, 2022 •
edited
Loading

@bogdandrutu We should have kept this issue open. There is some work that still needed to be done on exporters.

PRs to review:

#14749
#14773

We still have to work on the following exporters: (I can wrap it up sometime on the next week)

  • logzioexporter
  • opencensusexporter
  • parquetexporter
  • prometheusexporter
  • prometheusremotewriteexporter
  • pulsarexporter
  • sapmexporter
  • sentryexporter
  • signalfxexporter
  • skywalkingexporter
  • splunkhecexporter
  • sumologicexporter
  • tanzuobservabilityexporter
  • tencentcloudlogserviceexporter
  • zipkinexporter

@mx-psi mx-psi reopened this Oct 7, 2022
@kovrus kovrus mentioned this issue Oct 14, 2022
Merged
15 tasks
@kovrus
Copy link
Member

kovrus commented Oct 14, 2022

@bogdandrutu these two PRs should be merged to close this issue.

#14749
#14954

@kovrus
Copy link
Member

kovrus commented Oct 21, 2022

@mx-psi can you please close this issue?

@mx-psi mx-psi closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bogdandrutu @mx-psi @dmitryax @kovrus