[chore] use status type in basicauthextension (#21278)

extension/basicauthextension/config_test.go

@@ -22,6 +22,8 @@ import (
 	"github.com/stretchr/testify/require"
 	"go.opentelemetry.io/collector/component"
 	"go.opentelemetry.io/collector/confmap/confmaptest"
+
+	"github.com/open-telemetry/opentelemetry-collector-contrib/extension/basicauthextension/internal/metadata"
 )
 
 func TestLoadConfig(t *testing.T) {
@@ -33,19 +35,19 @@ func TestLoadConfig(t *testing.T) {
 		expectedErr bool
 	}{
 		{
-			id:          component.NewID(typeStr),
+			id:          component.NewID(metadata.Type),
 			expectedErr: true,
 		},
 		{
-			id: component.NewIDWithName(typeStr, "server"),
+			id: component.NewIDWithName(metadata.Type, "server"),
 			expected: &Config{
 				Htpasswd: &HtpasswdSettings{
 					Inline: "username1:password1\nusername2:password2\n",
 				},
 			},
 		},
 		{
-			id: component.NewIDWithName(typeStr, "client"),
+			id: component.NewIDWithName(metadata.Type, "client"),
 			expected: &Config{
 				ClientAuth: &ClientAuthSettings{
 					Username: "username",
@@ -54,7 +56,7 @@ func TestLoadConfig(t *testing.T) {
 			},
 		},
 		{
-			id:          component.NewIDWithName(typeStr, "both"),
+			id:          component.NewIDWithName(metadata.Type, "both"),
 			expectedErr: true,
 		},
 	}

extension/basicauthextension/factory.go

@@ -23,14 +23,10 @@ import (
 	"github.com/open-telemetry/opentelemetry-collector-contrib/extension/basicauthextension/internal/metadata"
 )
 
-const (
-	typeStr = "basicauth"
-)
-
 // NewFactory creates a factory for the static bearer token Authenticator extension.
 func NewFactory() extension.Factory {
 	return extension.NewFactory(
-		typeStr,
+		metadata.Type,
 		createDefaultConfig,
 		createExtension,
 		metadata.Stability,

extension/basicauthextension/factory_test.go

@@ -22,6 +22,8 @@ import (
 	"go.opentelemetry.io/collector/component"
 	"go.opentelemetry.io/collector/component/componenttest"
 	"go.opentelemetry.io/collector/extension/extensiontest"
+
+	"github.com/open-telemetry/opentelemetry-collector-contrib/extension/basicauthextension/internal/metadata"
 )
 
 func TestCreateDefaultConfig(t *testing.T) {
@@ -54,5 +56,5 @@ func TestCreateExtension_ValidConfig(t *testing.T) {
 func TestNewFactory(t *testing.T) {
 	f := NewFactory()
 	assert.NotNil(t, f)
-	assert.Equal(t, f.Type(), component.Type(typeStr))
+	assert.Equal(t, f.Type(), component.Type(metadata.Type))
 }

extension/basicauthextension/metadata.yaml

@@ -1,4 +1,4 @@
-type: basicauthextension
+type: basicauth
 
 status:
   class: extension