resolve comments

Signed-off-by: whitneygriffith <[email protected]>
open-telemetry · Oct 28, 2024 · 43c86d4 · 43c86d4
1 parent e504385
commit 43c86d4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/exporter/azuremonitorexporter/trace_to_envelope.go b/exporter/azuremonitorexporter/trace_to_envelope.go
@@ -106,7 +106,7 @@ func spanToTelemetryTraces(
 		spanEvent := span.Events().At(i)
 
 		// Skip non-exception events if configured
-		if spanEvent.Name() != exceptionSpanEventName && !spanEventsEnabled {
+		if !spanEventsEnabled && spanEvent.Name() != exceptionSpanEventName {
 			continue
 		}
 

diff --git a/exporter/azuremonitorexporter/traceexporter_test.go b/exporter/azuremonitorexporter/traceexporter_test.go
@@ -91,7 +91,7 @@ func TestExporterTraceDataCallbackSingleSpanWithSpanEvents(t *testing.T) {
 }
 
 // Tests the export onTraceData callback with a single Span that fails to produce an envelope
-// TODO: Depercate this test when transport channel is removed as we will not be using envelopes anymore
+// TODO: Deprecate this test when transport channel is removed as we will not be using envelopes anymore
 func TestExporterTraceDataCallbackSingleSpanNoEnvelope(t *testing.T) {
 	mockTransportChannel := getMockTransportChannel()
 	mockTelemetryClient := getMockTelemetryClient()
@@ -144,4 +144,4 @@ func getExporter(config *Config, transportChannel transportChannel, telemetryCli
 		telemetryClient:  telemetryClient,
 		logger:           zap.NewNop(),
 	}
-}
+}