Skip to content

Commit

Permalink
[pkg/stanza] Migrate keyvalue_parser config unmarshal tests to confma…
Browse files Browse the repository at this point in the history
…ptest (#13536)
  • Loading branch information
djaglowski authored Aug 24, 2022
1 parent 67448b9 commit 383db3a
Show file tree
Hide file tree
Showing 10 changed files with 114 additions and 111 deletions.
169 changes: 82 additions & 87 deletions pkg/stanza/operator/parser/keyvalue/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
package keyvalue

import (
"path/filepath"
"testing"

"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/entry"
Expand All @@ -22,92 +23,86 @@ import (
)

func TestConfig(t *testing.T) {
cases := []operatortest.ConfigUnmarshalTest{
{
Name: "default",
Expect: defaultCfg(),
operatortest.ConfigUnmarshalTests{
DefaultConfig: NewConfig(),
TestsFile: filepath.Join(".", "testdata", "config.yaml"),
Tests: []operatortest.ConfigUnmarshalTest{
{
Name: "default",
Expect: NewConfig(),
},
{
Name: "parse_from_simple",
Expect: func() *Config {
cfg := NewConfig()
cfg.ParseFrom = entry.NewBodyField("from")
return cfg
}(),
},
{
Name: "parse_to_simple",
Expect: func() *Config {
cfg := NewConfig()
cfg.ParseTo = entry.NewBodyField("log")
return cfg
}(),
},
{
Name: "on_error_drop",
Expect: func() *Config {
cfg := NewConfig()
cfg.OnError = "drop"
return cfg
}(),
},
{
Name: "timestamp",
Expect: func() *Config {
cfg := NewConfig()
parseField := entry.NewBodyField("timestamp_field")
newTime := helper.TimeParser{
LayoutType: "strptime",
Layout: "%Y-%m-%d",
ParseFrom: &parseField,
}
cfg.TimeParser = &newTime
return cfg
}(),
},
{
Name: "severity",
Expect: func() *Config {
cfg := NewConfig()
parseField := entry.NewBodyField("severity_field")
severityField := helper.NewSeverityConfig()
severityField.ParseFrom = &parseField
mapping := map[interface{}]interface{}{
"critical": "5xx",
"error": "4xx",
"info": "3xx",
"debug": "2xx",
}
severityField.Mapping = mapping
cfg.Config = &severityField
return cfg
}(),
},
{
Name: "delimiter",
Expect: func() *Config {
cfg := NewConfig()
cfg.Delimiter = ";"
return cfg
}(),
},
{
Name: "pair_delimiter",
Expect: func() *Config {
cfg := NewConfig()
cfg.PairDelimiter = ";"
return cfg
}(),
},
},
{
Name: "parse_from_simple",
Expect: func() *Config {
cfg := defaultCfg()
cfg.ParseFrom = entry.NewBodyField("from")
return cfg
}(),
},
{
Name: "parse_to_simple",
Expect: func() *Config {
cfg := defaultCfg()
cfg.ParseTo = entry.NewBodyField("log")
return cfg
}(),
},
{
Name: "on_error_drop",
Expect: func() *Config {
cfg := defaultCfg()
cfg.OnError = "drop"
return cfg
}(),
},
{
Name: "timestamp",
Expect: func() *Config {
cfg := defaultCfg()
parseField := entry.NewBodyField("timestamp_field")
newTime := helper.TimeParser{
LayoutType: "strptime",
Layout: "%Y-%m-%d",
ParseFrom: &parseField,
}
cfg.TimeParser = &newTime
return cfg
}(),
},
{
Name: "severity",
Expect: func() *Config {
cfg := defaultCfg()
parseField := entry.NewBodyField("severity_field")
severityField := helper.NewSeverityConfig()
severityField.ParseFrom = &parseField
mapping := map[interface{}]interface{}{
"critical": "5xx",
"error": "4xx",
"info": "3xx",
"debug": "2xx",
}
severityField.Mapping = mapping
cfg.Config = &severityField
return cfg
}(),
},
{
Name: "delimiter",
Expect: func() *Config {
cfg := defaultCfg()
cfg.Delimiter = ";"
return cfg
}(),
},
{
Name: "pair_delimiter",
Expect: func() *Config {
cfg := defaultCfg()
cfg.PairDelimiter = ";"
return cfg
}(),
},
}

for _, tc := range cases {
t.Run(tc.Name, func(t *testing.T) {
tc.RunDeprecated(t, defaultCfg())
})
}
}

func defaultCfg() *Config {
return NewConfig()
}.Run(t)
}
32 changes: 32 additions & 0 deletions pkg/stanza/operator/parser/keyvalue/testdata/config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
default:
type: key_value_parser
delimiter:
type: key_value_parser
delimiter: ";"
on_error_drop:
type: key_value_parser
on_error: drop
pair_delimiter:
type: key_value_parser
pair_delimiter: ";"
parse_from_simple:
type: key_value_parser
parse_from: body.from
parse_to_simple:
type: key_value_parser
parse_to: body.log
severity:
type: key_value_parser
severity:
parse_from: body.severity_field
mapping:
critical: 5xx
error: 4xx
info: 3xx
debug: 2xx
timestamp:
type: key_value_parser
timestamp:
parse_from: body.timestamp_field
layout_type: strptime
layout: '%Y-%m-%d'
1 change: 0 additions & 1 deletion pkg/stanza/operator/parser/keyvalue/testdata/default.yaml

This file was deleted.

2 changes: 0 additions & 2 deletions pkg/stanza/operator/parser/keyvalue/testdata/delimiter.yaml

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

8 changes: 0 additions & 8 deletions pkg/stanza/operator/parser/keyvalue/testdata/severity.yaml

This file was deleted.

5 changes: 0 additions & 5 deletions pkg/stanza/operator/parser/keyvalue/testdata/timestamp.yaml

This file was deleted.

0 comments on commit 383db3a

Please sign in to comment.