Skip to content

Commit

Permalink
[exporter/coralogixexporter] Make coralogixexporter default to gzip (#…
Browse files Browse the repository at this point in the history
…20336)

Makes coralogixexporter use gzip for logs and traces

Link to tracking Issue: #20337
  • Loading branch information
povilasv authored Mar 29, 2023
1 parent f43bd29 commit 28391da
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 10 deletions.
16 changes: 16 additions & 0 deletions .chloggen/coralogix-gzip.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: coralogixexporter

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: "Change coralogixexporter to default to gzip compression for logs and traces"

# One or more tracking issues related to the change
issues: [20337]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
16 changes: 8 additions & 8 deletions exporter/coralogixexporter/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,12 @@ func TestLoadConfig(t *testing.T) {
WriteBufferSize: 512 * 1024,
},
Logs: configgrpc.GRPCClientSettings{
Endpoint: "https://",
Endpoint: "https://",
Compression: "gzip",
},
Traces: configgrpc.GRPCClientSettings{
Endpoint: "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
Compression: "",
Compression: "gzip",
TLSSetting: configtls.TLSClientSetting{
TLSSetting: configtls.TLSSetting{},
Insecure: false,
Expand All @@ -74,8 +75,7 @@ func TestLoadConfig(t *testing.T) {
BalancerName: "",
},
GRPCClientSettings: configgrpc.GRPCClientSettings{
Endpoint: "",
Compression: "",
Endpoint: "",
TLSSetting: configtls.TLSClientSetting{
TLSSetting: configtls.TLSSetting{},
Insecure: false,
Expand Down Expand Up @@ -109,11 +109,12 @@ func TestLoadConfig(t *testing.T) {
WriteBufferSize: 512 * 1024,
},
Logs: configgrpc.GRPCClientSettings{
Endpoint: "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
Endpoint: "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
Compression: "gzip",
},
Traces: configgrpc.GRPCClientSettings{
Endpoint: "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
Compression: "",
Compression: "gzip",
TLSSetting: configtls.TLSClientSetting{
TLSSetting: configtls.TLSSetting{},
Insecure: false,
Expand All @@ -128,8 +129,7 @@ func TestLoadConfig(t *testing.T) {
AppNameAttributes: []string{"service.namespace"},
SubSystemAttributes: []string{"service.name"},
GRPCClientSettings: configgrpc.GRPCClientSettings{
Endpoint: "",
Compression: "",
Endpoint: "",
TLSSetting: configtls.TLSClientSetting{
TLSSetting: configtls.TLSSetting{},
Insecure: false,
Expand Down
6 changes: 4 additions & 2 deletions exporter/coralogixexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ func createDefaultConfig() component.Config {
TimeoutSettings: exporterhelper.NewDefaultTimeoutSettings(),
// Traces GRPC client
Traces: configgrpc.GRPCClientSettings{
Endpoint: "https://",
Endpoint: "https://",
Compression: configcompression.Gzip,
},
Metrics: configgrpc.GRPCClientSettings{
Endpoint: "https://",
Expand All @@ -52,7 +53,8 @@ func createDefaultConfig() component.Config {
WriteBufferSize: 512 * 1024,
},
Logs: configgrpc.GRPCClientSettings{
Endpoint: "https://",
Endpoint: "https://",
Compression: configcompression.Gzip,
},
PrivateKey: "",
AppName: "",
Expand Down

0 comments on commit 28391da

Please sign in to comment.