Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content_hash of Downloadable file needs to define hashing method #67

Closed
tigrannajaryan opened this issue Feb 28, 2022 · 0 comments · Fixed by #68
Closed

content_hash of Downloadable file needs to define hashing method #67

tigrannajaryan opened this issue Feb 28, 2022 · 0 comments · Fixed by #68

Comments

@tigrannajaryan
Copy link
Member

Without specifying the hashing method it is a useless for the purposes it claims to exist for

The hash of the file content. Can be used by the Agent to verify that the file was downloaded correctly.

You can't verify that the hash matches the content if you don't know the hashing method.
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Mar 2, 2022
@tigrannajaryan
Define that DownloadFile content hash method is SHA256
0d87698 
Resolves open-telemetry#67

Without specifying the hashing method it was useless for the purposes it claims to exist for
>The hash of the file content. Can be used by the Agent to verify that the file was downloaded correctly.

You can't verify that the hash matches the content if you don't know the hashing method.

Now it is precisely defined to be SHA256 of the content.
@tigrannajaryan tigrannajaryan mentioned this issue Mar 2, 2022
Merged
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Mar 9, 2022
@tigrannajaryan
Define that DownloadFile content hash method is SHA256
dd72c0e 
Resolves open-telemetry#67

Without specifying the hashing method it was useless for the purposes it claims to exist for
>The hash of the file content. Can be used by the Agent to verify that the file was downloaded correctly.

You can't verify that the hash matches the content if you don't know the hashing method.

Now it is precisely defined to be SHA256 of the content.
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Mar 9, 2022
@tigrannajaryan
Define that DownloadFile content hash method is SHA256
a79fee1 
Resolves open-telemetry#67

Without specifying the hashing method it was useless for the purposes it claims to exist for
>The hash of the file content. Can be used by the Agent to verify that the file was downloaded correctly.

You can't verify that the hash matches the content if you don't know the hashing method.

Now it is precisely defined to be SHA256 of the content.
tigrannajaryan added a commit that referenced this issue Mar 22, 2022
@tigrannajaryan
Define that DownloadFile content hash method is SHA256 (#68)
410dc86 
Resolves #67

Without specifying the hashing method it was useless for the purposes it claims to exist for
>The hash of the file content. Can be used by the Agent to verify that the file was downloaded correctly.

You can't verify that the hash matches the content if you don't know the hashing method.

Now it is precisely defined to be SHA256 of the content.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define that DownloadFile content hash method is SHA256 tigrannajaryan/opamp-spec
1 participant
@tigrannajaryan