Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework progress code for optimal retention #124

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Rework progress code for optimal retention #124

merged 1 commit into from
Nov 26, 2023

Conversation

dae
Copy link
Collaborator

@dae dae commented Nov 26, 2023

  • The Brent method makes it harder to predict how many iterations will be required, so don't set a total; the frontend will just display the number of elapsed iterations.
  • Make sure the progress gets updated during the initial bracket, for better feedback and so the user can cancel faster.

@dae
Rework progress code for optimal retention
51fb9fe 
- The Brent method makes it harder to predict how many iterations will
be required, so don't set a total; the frontend will just display the
number of elapsed iterations.
- Make sure the progress gets updated during the initial bracket, for
better feedback and so the user can cancel faster.
@L-M-Sherlock L-M-Sherlock self-requested a review November 26, 2023 05:27
@L-M-Sherlock L-M-Sherlock merged commit 96ae7fc into main Nov 26, 2023
3 checks passed
@L-M-Sherlock L-M-Sherlock deleted the opt-retention-fix branch November 26, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-M-Sherlock L-M-Sherlock L-M-Sherlock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dae @L-M-Sherlock