Update eval_cancel_error logic to separate context canceled, timeout errors #7202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchitten
force-pushed
the
context-error-handling
branch
from
b162ab4 to
2f52bb2
Compare
This changes the `eval_cancel_error` logic to differentiate between context.Canceled and context.DeadlineExceeded errors, because they are distinct errors. By differentiating here, callers will be able to determine if a call was stopped because a caller stopped the request, or because the request went over some imposed deadline. Signed-off-by: Mike Chittenden <[email protected]>
mchitten
force-pushed
the
context-error-handling
branch
from
2f52bb2 to
5bc8776
Compare
|
Looking at the test failures, seems like they might be flakes fixed by #7188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
While the
eval_cancel_error: caller cancelled query executionerror is useful in identifying requests that stopped, I propose that it's a little too vague because it absorbs bothcontext.Canceledandcontext.DeadlineExceedederrors. It's useful to differentiate these errors as it gives a clue to whether the user intentionally stopped the request, or the request exeeded some deadline from the caller. Without a change similar to this, it's much more difficult to tell why a call toEvalfailed.What are the changes in this PR?
This adds logic to
topdown/eval.goto differentiate context errors. It has the sameeval_cancel_errorprefix as before, but can now return an error that gives more clues:Notes to assist PR review:
Further comments:
An alternative here could be just to return the
e.ctx.Err()in the existing logic, but that does retain the more vague error message.