Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to not use reflect.DeepEqual on errors #7238

Closed
anderseknert opened this issue Dec 23, 2024 · 1 comment · Fixed by #7311
Closed

Update tests to not use reflect.DeepEqual on errors #7238

anderseknert opened this issue Dec 23, 2024 · 1 comment · Fixed by #7311

Comments

@anderseknert
Copy link
Member

Hacking on the OPA repo in VS Code and I'm seeing a bunch of warnings from the language server about us using reflect.DeepEqual to compare errors. This is apparently problematic for... reasons, as described here and elsewhere. Don't have time to spend on this tonight, but noting it down so that we can fix this and enable whatever linter is flagging this issue, as it seems legit to me.

Copy link

stale bot commented Jan 24, 2025

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days. Although currently inactive, the issue could still be considered and actively worked on in the future. More details about the use-case this issue attempts to address, the value provided by completing it or possible solutions to resolve it would help to prioritize the issue.

@stale stale bot added the inactive label Jan 24, 2025
anderseknert added a commit to anderseknert/opa that referenced this issue Jan 24, 2025
I pushed most of these fixed previously but these ones required
more work. Probably more work that it was worth, lol, but now the
work is done... and at least we can add this to the list of enabled
checks.

Fixes open-policy-agent#7238

Signed-off-by: Anders Eknert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant