Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar: allow import between rules and complex expression in else statement #80

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

vgramer
Copy link
Member

@vgramer vgramer commented Jan 2, 2021

Description

Fix grammar to:

  • allow imports between rules. Consequently, remove the useless grammar rule policy.
  • allow expr2 instead of term grammar rule in else statement

release notes

grammar: allow import between rules and complex expression in else statement

Fixes #76
Fixes #78

Special notes for your reviewer

'else keyword' and 'else keyword 2' tests have been merged into 'else keyword' test

also merge 'else keyword' and 'else keyword 2' tests into 'else keyword'

Signed-off-by: Vincent Gramer <[email protected]>
@vgramer vgramer force-pushed the fix_grammar_import_else branch from a710c75 to 0de7b98 Compare January 2, 2021 18:29
@vgramer vgramer self-assigned this Jan 2, 2021
Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests look great 👍

Copy link

@lkadalski lkadalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor 👍

@vgramer vgramer merged commit 85c8e55 into master Jan 4, 2021
@vgramer vgramer deleted the fix_grammar_import_else branch January 4, 2021 13:03
@vgramer vgramer added area/grammar issue or pr related to the grammar kind/bug Categorizes issue or PR as related to a bug labels Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grammar issue or pr related to the grammar kind/bug Categorizes issue or PR as related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grammar: infix operation should be allowed in else statement Grammar: imports could be defined between rule
3 participants