-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some user and tech doc #3
Conversation
Also: - move go license to docs/devel - add opa version requirement - correct some english mistake the documentation is not complete, but it's a beginning Signed-off-by: Vincent Gramer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks really good with the explanatory notes! 👍
The changes are really nitpicky that I kept making as I read the PR.
src/test/kotlin/org/openpolicyagent/ideaplugin/OpaWithRealProjectTestBase.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/openpolicyagent/ideaplugin/OpaWithRealProjectTestBase.kt
Outdated
Show resolved
Hide resolved
...test/kotlin/org/openpolicyagent/ideaplugin/ide/runconfig/test/OpaTestRunConfigurationBase.kt
Outdated
Show resolved
Hide resolved
...test/kotlin/org/openpolicyagent/ideaplugin/ide/runconfig/test/OpaTestRunConfigurationBase.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/openpolicyagent/ideaplugin/lang/RegoParsingTestCaseBase.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Asad <[email protected]>
@asadali thanks a lot for the review ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments/questions. Overall ok, I'm not an expert in writing doc 😄
Signed-off-by: Vincent Gramer <[email protected]>
it's not complete but it's a beginning
user documentation
tech doc