Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use nindent instead of indent in resources for mgmt deployment #170

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

kleug
Copy link

@kleug kleug commented Aug 19, 2022

resolve #168

Actually with the chart release (7.0.6) when you try to set some specific resource limits to the kube-mgmt deployment like for exemple.

mgmt:
  limits:
    cpu: 0.5
    memory: 128Mi
  requests:
    cpu: 0.1
    memory: 64Mi

The release will fail because of the render of the deployment.yaml
For fix it we need to give the correct indent to the added ressource.

Signed-off-by: Remy Genisson [email protected]

Copy link
Contributor

@eshepelyuk eshepelyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz, make more meaningful commit message

@kleug kleug requested a review from eshepelyuk August 19, 2022 15:03
Copy link
Contributor

@eshepelyuk eshepelyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and fixup into a single commit, then Im ready to merge and release.

Signed-off-by: Remy Genisson <[email protected]>
Signed-off-by: Remy Genisson <[email protected]>
@kleug kleug requested a review from eshepelyuk August 22, 2022 10:32
@eshepelyuk eshepelyuk merged commit 5d94d29 into open-policy-agent:master Aug 22, 2022
@eshepelyuk eshepelyuk changed the title correct indent use nindent instead of indent in resources for mgmt deployment Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad indents: can't specify resources for mgmt
2 participants