Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: cli attributes normalization #151

Merged
merged 2 commits into from
May 10, 2022
Merged

feat!: cli attributes normalization #151

merged 2 commits into from
May 10, 2022

Conversation

eshepelyuk
Copy link
Contributor

@eshepelyuk eshepelyuk commented May 6, 2022

  • label is always required on config map to be picked up as policy or
    data
  • confusing --policies renamed to --namespaces
  • introduce configuration attributes for data labels, similar to policies
  • --enable-data is true by default
  • helm values adjusted accordingly

Signed-off-by: Ievgenii Shepeliuk [email protected]

@eshepelyuk eshepelyuk marked this pull request as draft May 6, 2022 18:08
@eshepelyuk eshepelyuk force-pushed the fix/ns branch 4 times, most recently from 66bb7c3 to a4013c8 Compare May 6, 2022 20:16
@eshepelyuk eshepelyuk changed the base branch from fix/nossl to master May 6, 2022 20:16
@eshepelyuk eshepelyuk marked this pull request as ready for review May 6, 2022 20:19
eshepelyuk added 2 commits May 7, 2022 08:58
* make dedicated label mandatory on config map to be used as policy/data
* confusing attribute --policies renamed to --namespaces
* new configuration attributes for data label/value, similar to policies
* --enable-data is true by default

Signed-off-by: Ievgenii Shepeliuk <[email protected]>
Signed-off-by: Ievgenii Shepeliuk <[email protected]>
@eshepelyuk eshepelyuk merged commit ef5fac5 into master May 10, 2022
@eshepelyuk eshepelyuk deleted the fix/ns branch May 13, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant