Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: property to disable https in opa server #145

Merged
merged 2 commits into from
May 6, 2022
Merged

Conversation

eshepelyuk
Copy link
Contributor

@eshepelyuk eshepelyuk commented May 3, 2022

Hello, some points except the new itself

  1. kube-mgmt is installed by default now, because I have no idea why it was not before :( The entire chart is about kube-mgmt, so it makes sense to install it by default.
  2. Added initial e2e test for a default chart values.
  3. Removed pod-only (127.0.0.1) OPA listener, since there's a public OPA listener exposed anyway - kube-mgmt can reuse it and chart simplified a bit.

Signed-off-by: Ievgenii Shepeliuk [email protected]

Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have you back!

@eshepelyuk eshepelyuk force-pushed the fix/nossl branch 2 times, most recently from f2782a7 to 03f1a93 Compare May 3, 2022 16:23
@eshepelyuk eshepelyuk marked this pull request as draft May 4, 2022 03:45
@eshepelyuk eshepelyuk marked this pull request as ready for review May 4, 2022 10:27
@eshepelyuk eshepelyuk force-pushed the fix/nossl branch 10 times, most recently from d6eea91 to c7979e7 Compare May 6, 2022 07:29
@eshepelyuk eshepelyuk merged commit fc5e99e into master May 6, 2022
@eshepelyuk eshepelyuk deleted the fix/nossl branch May 6, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants