Make cert-manager certs duration configurable #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Lossent <[email protected]>
alexcern
force-pushed
the
cert-manager-cert-lifetime
branch
from
6cc2fa1 to
14bdf3c
Compare
|
Thanks for the reminder @eshepelyuk, should be OK now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcoded certificate duration when using cert-manager may be insufficient in some cases (compare to using
generateCerts, which creates certificate with 10 year validity).In this proposal, the duration of the certificates generated by cert-manager is made configurable. The previously hardcoded values are retained as default values (5y for CA and 1y for serving certificate).