-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: simplify rbac creation #108
Conversation
Signed-off-by: Ievgenii Shepeliuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eshepelyuk have you tested these changes ?
Of course. |
Hey @eshepelyuk just wondering with this change how can you now set rbac rules to allow to allow permissions to replicate other k8s objects such as ingresses or deployments? |
Hey @CarloColumna If you have a general question, there is OPA slack. If you have specific question to me - I am there in OPA slack. If there is a bug / regression / improvement - plz open an issue. Just pick up one of the options. |
I'll message you in Slack |
@eshepelyuk I don't think there's anything wrong with asking questions on a closed issue or PR - that's often how people find their particular issue when searching for solutions. While moving the discussion to Slack might help whoever asked, it won't benefit anyone else looking for an answer to the same question. Definitely agree though that a new issue is the way to go if something is currently not working as expected. |
did you get an answer to your question? if so what is the answer? it is completely unclear to me how I would create RBAC rules for replicating objects with the chart |
Hey @bjhaid , unfortunately I din't get a helpful answer. I think the way to fix this is to revert some of the changes done by this change through a new issue and then have it approved and merged. I was planning to do it but got caught up with other things. One workaround I did is to use a custom helm chart until this upstream chart gets fixed. |
Feel free to submit a PR for this @CarloColumna 👍 |
Signed-off-by: Ievgenii Shepeliuk [email protected]