Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add k8s 1.27 to tests #2692

Merged
merged 6 commits into from
May 1, 2023

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Apr 12, 2023

What this PR does / why we need it:
marking as draft since i don't think kubebuilder tools are out yet

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@sozercan sozercan marked this pull request as ready for review April 17, 2023 22:49
@sozercan sozercan marked this pull request as draft April 17, 2023 22:52
@sozercan sozercan marked this pull request as ready for review April 26, 2023 21:22
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (124c600) 52.78% compared to head (5c91b33) 52.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2692      +/-   ##
==========================================
- Coverage   52.78%   52.73%   -0.05%     
==========================================
  Files         123      123              
  Lines       10941    10941              
==========================================
- Hits         5775     5770       -5     
- Misses       4710     4714       +4     
- Partials      456      457       +1     
Flag Coverage Δ
unittests 52.73% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sozercan sozercan requested a review from a team April 28, 2023 02:01
Copy link
Contributor

@nilekhc nilekhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nilekhc
Copy link
Contributor

nilekhc commented Apr 28, 2023

@sozercan Do you want to squash commits?

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit c02b1d5 into open-policy-agent:master May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants