fix: handle empty spec for modifyset #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Pana <[email protected]>
acpana
commented
Feb 16, 2023
| @@ -138,7 +138,7 @@ func MutatorForModifySet(modifySet *mutationsunversioned.ModifySet) (*Mutator, e | |||
| return nil, fmt.Errorf("modifyset %s can't change metadata", modifySet.GetName()) | |||
| } | |||
|
|
|||
| if path.Nodes[len(path.Nodes)-1].Type() == parser.ListNode { | |||
| if len(path.Nodes) > 0 && path.Nodes[len(path.Nodes)-1].Type() == parser.ListNode { | |||
There was a problem hiding this comment.
empty spec leads to empty path which panics. I've added unit tests for all mutators that don't have an empty spec test case to enforce graceful handling of an empty spec.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2585 +/- ##
=========================================
Coverage ? 53.58%
=========================================
Files ? 120
Lines ? 10634
Branches ? 0
=========================================
Hits ? 5698
Misses ? 4504
Partials ? 432
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ritazh
reviewed
Feb 17, 2023
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 7, 2023
Signed-off-by: Alex Pana <[email protected]> Co-authored-by: Max Smythe <[email protected]>
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 8, 2023
Signed-off-by: Alex Pana <[email protected]> Co-authored-by: Max Smythe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2574