-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce gci
to unify the order of package import
#2545
Conversation
gci
to unify the order of package importgci
to unify the order of package import
Codecov ReportBase: 53.41% // Head: 53.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2545 +/- ##
=======================================
Coverage 53.41% 53.42%
=======================================
Files 120 120
Lines 10643 10643
=======================================
+ Hits 5685 5686 +1
+ Misses 4521 4520 -1
Partials 437 437
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Fish-pro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR!
…cy-agent#2545) Introduce gci to unify the order of package import Signed-off-by: Fish-pro <[email protected]> Co-authored-by: Rita Zhang <[email protected]>
Signed-off-by: Fish-pro [email protected]
What this PR does / why we need it:
The order of package import for some files in the code is not uniform, and this pr introduces
gci
to regulate package import orderWhich issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: