feat: vap update to reduce operations, v1beta1, and fail open #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rita Zhang <[email protected]>
ritazh
force-pushed
the
vap-operations-failpolicy
branch
from
03be6f6 to
fe02898
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master open-policy-agent/frameworks#397 +/- ##
==========================================
- Coverage 54.68% 54.68% -0.01%
==========================================
Files 71 71
Lines 5239 5241 +2
==========================================
+ Hits 2865 2866 +1
- Misses 2072 2073 +1
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sozercan
reviewed
Feb 17, 2024
| Operations: []admissionregistrationv1alpha1.OperationType{admissionregistrationv1alpha1.OperationAll}, | ||
| Rule: admissionregistrationv1alpha1.Rule{APIGroups: []string{"*"}, APIVersions: []string{"*"}, Resources: []string{"*"}}, | ||
| RuleWithOperations: admissionregistrationv1beta1.RuleWithOperations{ | ||
| /// TODO(ritazh): default for now until we can safely expose these to users |
There was a problem hiding this comment.
please create an issue or add to an existing tracking issue so we dont forget this
There was a problem hiding this comment.
sozercan
reviewed
Feb 17, 2024
| func (in *Source) GetV1alpha1FailurePolicy() (*admissionv1alpha1.FailurePolicyType, error) { | ||
| func (in *Source) GetV1Beta1FailurePolicy() (*admissionv1beta1.FailurePolicyType, error) { | ||
| var out admissionv1beta1.FailurePolicyType | ||
| /// TODO(ritazh): default for now until the feature is safe to fail close |
sozercan
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.