Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate code, add Context-awareness to CreateUser and UpdateUser, update doc and move UpdateUser func #15

Merged
merged 11 commits into from
Aug 18, 2021
Merged

Remove duplicate code, add Context-awareness to CreateUser and UpdateUser, update doc and move UpdateUser func #15

merged 11 commits into from
Aug 18, 2021

Conversation

TerraTalpi
Copy link
Contributor

@TerraTalpi TerraTalpi commented Aug 18, 2021 •
edited
Loading

This PR does the following:

  • remove duplicate code for makeGETAPICall, makePOSTAPICall and makePatchAPICall. Create wrapper makeAPICall for that.
  • add context-awareness to CreateUser and UpdateUser
  • Move UpdateUser from GraphClient.go to User.go
  • update documentation for context-awareness with the new functions

@TerraTalpi TerraTalpi added the enhancement New feature or request label Aug 18, 2021
@TerraTalpi TerraTalpi added this to the v0.2.0 milestone Aug 18, 2021
@TerraTalpi TerraTalpi self-assigned this Aug 18, 2021
@TerraTalpi TerraTalpi changed the title Add Context-awareness to CreateUser and UpdateUser, update doc and move UpdateUser func Remove duplicate code, add Context-awareness to CreateUser and UpdateUser, update doc and move UpdateUser func Aug 18, 2021
@TerraTalpi TerraTalpi merged commit 7a1eecd into master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TerraTalpi TerraTalpi

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@TerraTalpi