v2.0.x: disable hwloc CUDA support when relevant #4249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsquyres yeah let's fix this in 2.0.x too. |
|
Working through issues identified on #4251. |
jsquyres
force-pushed
the
pr/v2.0.x/disable-hwloc-cuda-when-relevant
branch
from
2c53f3e to
67fbad3
Compare
|
@ggouaillardet New commit added to this v2.x PR. |
Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit f5d51dc)
Open MPI doesn't use GL or OpenCL OS devices, so just disable them in hwloc. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 84a721d)
Be a little more deliberate about convering OMPI's --with-cuda CLI value to hwloc's --enable-cuda configure option. Also, unconditionally disable hwloc NVML support (because Open MPI is not currently using it). Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 2ec2a32)
There is no usage of CUDA hwloc objects in the v2.0.x branch, and linking in CUDA can cause problems (per open-mpi#4257 (comment)). Partially cherry-picked from c341b53. Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/v2.0.x/disable-hwloc-cuda-when-relevant
branch
from
9b6000e to
f28fcbe
Compare
|
@hppritcha This v2.0.x PR updated. Can you review? |
hppritcha
approved these changes
Oct 10, 2017
|
had to kill off armv8 testing. |
|
bot:ompi:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #4248.
@hppritcha I'm not 100% convinced, but it may be desirable to commit this fix to the v2.0.x branch.