Topic/treematch #3960
Merged
Topic/treematch #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simply based on some local state. This is the second part of the patch proposed for open-mpi#1183. Signed-off-by: George Bosilca <[email protected]>
This fix is related to issue open-mpi#1877, and prevents the OMPI library from messing the user level random values. Signed-off-by: George Bosilca <[email protected]>
Including variable renaming and loop merging. Signed-off-by: George Bosilca <[email protected]>
Signed-off-by: George Bosilca <[email protected]>
Signed-off-by: George Bosilca <[email protected]>
Signed-off-by: George Bosilca <[email protected]>
Make sure the HWLOC topology is available as early as possible, so that we can fail graciously. Signed-off-by: George Bosilca <[email protected]>
|
@bosilca @GuillaumeMercier One of the commits on this PR was not signed off. Also, it looks like this PR is causing breakage on master -- compile failures in treematch. See https://gist.github.com/ibm-ompi/77c743d005e80b49ff9f634ce0400a16. Can one of you please investigate ASAP? If you guys can't fix this within the next hour or so, we should probably revert this PR until it can be fixed. Thanks! |
Merged
|
#4014 fixes the API change issue. I will merge as soon as all tests succeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the treematch-based topo support, including a newer version of treematch.
Fixes #1183.