Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io/ompio: move io/ompio functionality to common/ompio #1886

Merged
merged 6 commits into from
Jul 29, 2016

Conversation

edgargabriel
Copy link
Member

@edgargabriel edgargabriel commented Jul 19, 2016

  • set up the infrastructure for mca/common/ompio
  • move the printqueue functionality to its new location
  • move internal read/write/open/close functionality to its new location

@ibm-ompi
Copy link

Build Failed with GNU compiler! Please review the log, and get in touch if you have questions.

Gist: https://gist.github.com/ibm-ompi/56872b8a6e4819a04736383bc540bc5a

@jjhursey
Copy link
Member

bot:ibm:retest

@ibm-ompi
Copy link

Build Failed with GNU compiler! Please review the log, and get in touch if you have questions.

Gist: https://gist.github.com/bcc226e062d6899a1aadedf52dd3a3f8

@ibm-ompi
Copy link

Build Failed with XL compiler! Please review the log, and get in touch if you have questions.

Gist: https://gist.github.com/e5a54ec28f368e254569b6b5e82f67ce

@edgargabriel edgargabriel changed the title io/ompio: move printqueue functionality to common/ompio io/ompio: move io/ompio functionality to common/ompio Jul 21, 2016
@edgargabriel
Copy link
Member Author

bot:retest

@edgargabriel
Copy link
Member Author

the mellanox error has nothing to do with this pr. Will retry later again

--2016-07-28 23:12:28-- (try: 6) http://www.mcs.anl.gov/~thakur/thread-tests/thread-tests-1.1.tar.gz
23:12:28 Connecting to www.mcs.anl.gov|140.221.6.95|:80... failed: Connection timed out.
23:13:31 Retrying.

@jsquyres
Copy link
Member

@Di0gen @jladd-mlnx I've been told by the MPICH team that ANL's DNS can be flakey at times. You might want to get the 1.1 thread tests from the ompi-tests git repo instead...? Might be more reliable.

@edgargabriel
Copy link
Member Author

bot:mellanox:retest

@edgargabriel
Copy link
Member Author

As a small heads up: since this commit will require to re-autogen the source tree, I will wait until later tonight to merge it. It touches a lot of files (73), but all within the ompio universe. Most changes are also fairly minuscule (i.e. very often just changing an include statement in the file etc.)

@jsquyres
Copy link
Member

I wouldn't worry about requiring a re-autogen in the middle of the work day any more.

We used to, but a) autogen is faster these days, and b) laptops/servers are faster these days.

So while I appreciate your consideration of others, I don't think you need to wait. 😄

@edgargabriel
Copy link
Member Author

ok, sounds good :-) will merge .

@edgargabriel edgargabriel merged commit 160d9a7 into open-mpi:master Jul 29, 2016
@edgargabriel edgargabriel deleted the pr/ompio-reorg branch March 21, 2018 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants