Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix the logic of skipping loss in smplify #146

Merged
merged 6 commits into from
Apr 1, 2022

Conversation

yl-1993
Copy link
Collaborator

@yl-1993 yl-1993 commented Apr 1, 2022

No description provided.

@yl-1993 yl-1993 requested a review from caizhongang April 1, 2022 03:12
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #146 (954b88e) into main (99df7fc) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   85.12%   85.18%   +0.05%     
==========================================
  Files         169      169              
  Lines       13670    13789     +119     
==========================================
+ Hits        11637    11746     +109     
- Misses       2033     2043      +10     
Flag Coverage Δ
unittests 85.18% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmhuman3d/models/registrants/smplifyx.py 90.10% <ø> (ø)
mmhuman3d/models/losses/mse_loss.py 100.00% <100.00%> (ø)
mmhuman3d/models/registrants/smplify.py 90.69% <100.00%> (+0.17%) ⬆️
mmhuman3d/data/data_converters/agora.py 88.10% <0.00%> (-3.45%) ⬇️
mmhuman3d/data/data_structures/human_data_cache.py 96.49% <0.00%> (-1.39%) ⬇️
mmhuman3d/data/data_structures/human_data.py 99.08% <0.00%> (-0.16%) ⬇️
...n3d/core/conventions/keypoints_mapping/__init__.py 91.12% <0.00%> (+0.29%) ⬆️
mmhuman3d/data/data_converters/surreal.py 90.14% <0.00%> (+0.35%) ⬆️
mmhuman3d/data/datasets/human_image_dataset.py 93.07% <0.00%> (+1.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99df7fc...954b88e. Read the comment docs.

Copy link
Collaborator

@caizhongang caizhongang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@caizhongang caizhongang merged commit fb5ad0f into open-mmlab:main Apr 1, 2022
ttxskk pushed a commit that referenced this pull request Jun 17, 2022
* Revise default weight to None & add _skip_loss

* Convert None to none in mse_loss

* Modify default weight to None

* Add more details in comments

* Apply abs in computing relative change & add docs

* Revise comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants