Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for mask-free keypoints conversion #142

Merged
merged 6 commits into from
Apr 1, 2022

Conversation

caizhongang
Copy link
Collaborator

@caizhongang caizhongang commented Mar 30, 2022

Resolves #35 .

  • Add generate_mask_from_confidence in HumanData
  • Add return_mask switch in convert_kps that allow mask to be not returned

After much discussion, the team agree that:

  • Mask is not necessary when keypoints confidence is present
  • Mask will be kept to ensure forward compatibility

@caizhongang caizhongang changed the title Add support for mask-free keypoints conversion [Feature] Add support for mask-free keypoints conversion Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #142 (c9e92ac) into main (96517ae) will increase coverage by 0.17%.
The diff coverage is 99.00%.

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   84.95%   85.12%   +0.17%     
==========================================
  Files         169      169              
  Lines       13515    13744     +229     
==========================================
+ Hits        11482    11700     +218     
- Misses       2033     2044      +11     
Flag Coverage Δ
unittests 85.12% <99.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmhuman3d/data/data_structures/human_data.py 99.08% <98.94%> (+1.66%) ⬆️
...n3d/core/conventions/keypoints_mapping/__init__.py 91.12% <100.00%> (+0.29%) ⬆️
mmhuman3d/data/data_converters/agora.py 88.10% <0.00%> (-3.45%) ⬇️
...e/visualization/renderer/torch3d_renderer/utils.py 70.96% <0.00%> (-3.23%) ⬇️
mmhuman3d/models/registrants/smplify.py 90.52% <0.00%> (-3.10%) ⬇️
.../visualization/renderer/torch3d_renderer/meshes.py 86.99% <0.00%> (-0.87%) ⬇️
mmhuman3d/utils/mesh_utils.py 91.00% <0.00%> (ø)
mmhuman3d/models/losses/__init__.py 100.00% <0.00%> (ø)
mmhuman3d/data/data_converters/mpi_inf_3dhp.py 86.50% <0.00%> (ø)
...uman3d/core/visualization/visualize_keypoints2d.py 84.46% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e21e38...c9e92ac. Read the comment docs.

Copy link
Collaborator

@LazyBusyYang LazyBusyYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the warning caused by np.int is suppressed, everything is good to merge.

@caizhongang caizhongang requested a review from LazyBusyYang April 1, 2022 02:59
Copy link
Collaborator

@LazyBusyYang LazyBusyYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is OK. Good to go.

@LazyBusyYang LazyBusyYang merged commit 300ebfc into main Apr 1, 2022
@caizhongang caizhongang deleted the mask_to_conf_revised branch April 1, 2022 08:20
ttxskk pushed a commit that referenced this pull request Jun 17, 2022
*  Add generate_mask_from_confidence in HumanData

 * Add return_mask switch in convert_kps that allow mask to be not returned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: remove keypoint mask and use confidence only
2 participants