-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add the support for musa device support #1453
Conversation
…pped by find haowen.han
HI @hanhaowen-mt , thanks for your contribution. Have you validated this support in downstream repos? |
hi, I am still validating it yet |
It is a draft, I am still struggling with many problems..... |
目前mmcv已经适配完毕,但是还有些bug需要修复,由于mmengine是一个纯py代码库,所以我想可以先合入也不影响? |
|
98eb48e
to
243d093
Compare
Line 55 in 4a50213
https://github.com/open-mmlab/mmengine/pull/1453/files#diff-32b2a08b237dff2199ee47140807860c85574eab680060ce98ee4016866ddca1R17 这里 import 了 device 模块,device/utils.py 在这里 import 了 torch(https://github.com/open-mmlab/mmengine/pull/1453/files#diff-32b2a08b237dff2199ee47140807860c85574eab680060ce98ee4016866ddca1R17),所以会报错。 |
f7543e2
to
658a2f2
Compare
@hanhaowen-mt 你好,已完成 review,请根据 comment 进行修改。另外,想确认一下,此 PR 是否已在 mmdet 进行验证? |
cee8d80
to
aeb2a0a
Compare
@zhouzaida 修改完成,open-mmlab/mmdetection#11352 mmdet的pr也提了,都是验证过的 |
aeb2a0a
to
0a15a75
Compare
@hanhaowen-mt 最后一轮 comment 了,可以改完再验证一下,没问题就可以合了 |
0a15a75
to
a3431df
Compare
搞定了,这个pr先合了吧 |
@hanhaowen-mt 你好,mmengine/hooks/empty_cache_hook.py 这里可以再改一下,然后单元测试根据有没有 cuda skip 掉就行可以。修完这个就可以合了。 |
e99bf2c
to
f7c0b07
Compare
Co-authored-by: Zaida Zhou <[email protected]>
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers. By the way, if you're not familiar with how to use pre-commit to fix lint issues or add unit tests, please refer to Contributing to OpenMMLab.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist