-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeCamp2023-Task288] Add NeptuneVisBackend #1311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add Neptune backend to visualizer add TestNeptuneVisBackend test unit
Hi @wangerlie , thanks for your contribution. Could you help add the usage of Neptune in In addition, please also add |
zhouzaida
reviewed
Aug 17, 2023
zhouzaida
reviewed
Aug 17, 2023
Co-authored-by: Zaida Zhou <[email protected]>
Co-authored-by: Zaida Zhou <[email protected]>
zhouzaida
reviewed
Aug 17, 2023
zhouzaida
reviewed
Aug 17, 2023
Co-authored-by: Zaida Zhou <[email protected]>
Co-authored-by: Zaida Zhou <[email protected]>
zhouzaida
reviewed
Aug 17, 2023
Co-authored-by: Zaida Zhou <[email protected]>
zhouzaida
reviewed
Aug 17, 2023
Co-authored-by: Zaida Zhou <[email protected]>
zhouzaida
reviewed
Aug 17, 2023
Co-authored-by: Zaida Zhou <[email protected]>
zhouzaida
reviewed
Aug 17, 2023
Co-authored-by: Zaida Zhou <[email protected]>
1.fixed code according to the comments 2.add the usage of Neptune in docs also add NeptuneVisBackend in rst
zhouzaida
reviewed
Aug 17, 2023
zhouzaida
reviewed
Aug 17, 2023
Co-authored-by: Zaida Zhou <[email protected]>
Co-authored-by: Zaida Zhou <[email protected]>
zhouzaida
reviewed
Aug 17, 2023
zhouzaida
previously approved these changes
Aug 17, 2023
zhouzaida
reviewed
Aug 17, 2023
zhouzaida
reviewed
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CodeCamp2023
Modification
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
NO
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
NO
Checklist
add aditional unit test for Neptune backend test