Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-Task288] Add NeptuneVisBackend #1311

Merged
merged 18 commits into from
Aug 17, 2023
Merged

[CodeCamp2023-Task288] Add NeptuneVisBackend #1311

merged 18 commits into from
Aug 17, 2023

Conversation

wangerlie
Copy link
Contributor

Motivation

CodeCamp2023

Modification

  1. Add Neptune backend to visualizer. The original task is to add segmind, however the mentor suggest to use Neptune as backend instead after searching the docs about segmind and finding that it does not suit for the task.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

NO

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

NO

Checklist

add aditional unit test for Neptune backend test

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

add Neptune backend to visualizer
add TestNeptuneVisBackend test unit
@CLAassistant
Copy link

CLAassistant commented Aug 16, 2023

CLA assistant check
All committers have signed the CLA.

@zhouzaida zhouzaida changed the title [CodeCamp2023-Task288] [CodeCamp2023-Task288] Add NeptuneVisBackend Aug 17, 2023
@zhouzaida
Copy link
Collaborator

zhouzaida commented Aug 17, 2023

Hi @wangerlie , thanks for your contribution. Could you help add the usage of Neptune in docs/zh_cn/common_usage/visualize_training_log.md and docs/en/common_usage/visualize_training_log.md.

In addition, please also add NeptuneVisBackend in docs/en/api/visualization.rst and docs/en/api/visualization.rst.

wangerlie and others added 2 commits August 17, 2023 19:47
1.fixed code according to the comments
2.add the usage of Neptune in docs also add NeptuneVisBackend in rst
@wangerlie wangerlie requested a review from C1rN09 as a code owner August 17, 2023 12:10
zhouzaida
zhouzaida previously approved these changes Aug 17, 2023
@zhouzaida zhouzaida merged commit 43e308c into open-mmlab:main Aug 17, 2023
@fanqiNO1 fanqiNO1 mentioned this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants