Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update welcome page condition #19308

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Update welcome page condition #19308

merged 3 commits into from
Jan 10, 2025

Conversation

sweta1308
Copy link
Contributor

@sweta1308 sweta1308 commented Jan 10, 2025 •
edited by chirag-madlani
Loading

Set welcome page visible flag to true by default.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sweta1308 sweta1308 requested a review from a team as a code owner January 10, 2025 06:46
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

chirag-madlani
chirag-madlani previously approved these changes Jan 10, 2025
View reviewed changes
@chirag-madlani chirag-madlani added safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Jan 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.58% (40791/63166) 40.81% (16369/40114) 43.96% (4950/11260)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chirag-madlani chirag-madlani merged commit 63090da into open-metadata:main Jan 10, 2025
15 of 17 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Failed to cherry-pick changes to the 1.6.2 branch.
Please cherry-pick the changes manually.
You can find more details here.

chirag-madlani pushed a commit that referenced this pull request Jan 10, 2025
@sweta1308 @chirag-madlani
Update welcome page condition (#19308)
6fd13d9 
* update welcome page condition

* update Welcome page consition

* fix conditions

---------

Co-authored-by: Chirag Madlani <[email protected]>
(cherry picked from commit 63090da)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sweta1308 @chirag-madlani