Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: address dq feedback and move lineage tracing in observability layer #18751

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Minor: address dq feedback and move lineage tracing in observability layer #18751

merged 2 commits into from
Nov 23, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Nov 23, 2024 •
edited
Loading

Describe your changes:

  • Fix layout issue
image
  • Move DQ tracing to observability layer

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Nov 23, 2024
@ShaileshParmar11 ShaileshParmar11 self-assigned this Nov 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.6% (39859/62673) 40.19% (15842/39421) 42.39% (4733/11165)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ShaileshParmar11
Copy link
Contributor Author

Failing playwright is not relevant with changes

@ShaileshParmar11 ShaileshParmar11 merged commit 9edf379 into main Nov 23, 2024
12 of 16 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the dq-dashboard-feedback branch November 23, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaileshParmar11 @chirag-madlani