Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Teradata connector docs #16672

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Add Teradata connector docs #16672

merged 3 commits into from
Jun 18, 2024

Conversation

gpby
Copy link
Contributor

@gpby gpby commented Jun 15, 2024

Describe your changes:

As discussed in PR #16373 documentation for Teradata Connector has been added.

Type of change:

  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

To deploy OpenMetadata, check the Deployment guides.
{%/inlineCallout%}

Connector was tested on Teradata DBS version 17.20. Since there are no significant changes in metadata objects, so it should work with 15.x, 16.x versions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpby can we document what are the user permissions one needs to setup to get the metadata from Teradata?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default all Teradata users has access to metadata objects (dbc.tablesv, dbc.columnsv, etc.) because public role has access to those objects. So DBA should do some explicit revokes to limit access to metadata object (e.g. KB0024146)

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.19% (35193/53989) 42% (13921/33145) 43.94% (4319/9829)

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

cypress bot commented Jun 16, 2024

1 failed test on run #34406 ↗︎

1 544 417 0 Flakiness 0

Details:

Add Teradata doc
Project: openmetadata Commit: a3c7f51701
Status: Failed Duration: 21:33 💡
Started: Jun 16, 2024 8:33 PM Ended: Jun 16, 2024 9:55 PM
Failed  cypress/e2e/Service/ServiceIngestion.spec.ts • 1 failed test • cypress-ci-mysql-pr-9538616744-1

View Output Video

Test Artifacts
Superset Ingestion > Create & Ingest Superset service Screenshots Video

Review all test suite changes for PR #16672 ↗︎

@harshach harshach merged commit db959c3 into open-metadata:main Jun 18, 2024
43 of 52 checks passed
@gpby gpby deleted the teradata-doc branch June 22, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants