Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CI): Workflow that will take care of Release Version updates #16429

Merged
merged 2 commits into from
May 29, 2024
Merged

chore(CI): Workflow that will take care of Release Version updates #16429

merged 2 commits into from
May 29, 2024

Conversation

akash-jain-10
Copy link
Collaborator

Workflow that will take care of Release Version updates

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@akash-jain-10 akash-jain-10 requested a review from harshach as a code owner May 27, 2024 14:23
@akash-jain-10 akash-jain-10 requested a review from tutte May 27, 2024 14:23
@akash-jain-10 akash-jain-10 self-assigned this May 27, 2024
@github-actions github-actions bot added devops safe to test Add this label to run secure Github workflows on PRs labels May 27, 2024
@akash-jain-10 akash-jain-10 requested a review from Marcus1911 May 28, 2024 05:01
@Marcus1911
Copy link

@akash-jain-10 Should we add the ticket number to follow up?
Other than that, LGTM

tutte
tutte approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@tutte tutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if works 🚀

@tutte tutte enabled auto-merge (squash) May 29, 2024 07:54
@tutte tutte disabled auto-merge May 29, 2024 08:05
@tutte tutte merged commit 6688c08 into main May 29, 2024
11 checks passed
@tutte tutte deleted the feat/ci-create-release-branches branch May 29, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tutte tutte tutte approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@Marcus1911 Marcus1911 Awaiting requested review from Marcus1911

Assignees

@akash-jain-10 akash-jain-10

Labels
devops safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akash-jain-10 @Marcus1911 @tutte