Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: address ui feedback on data observability #16427

Merged
merged 2 commits into from
May 28, 2024
Merged

Minor: address ui feedback on data observability #16427

merged 2 commits into from
May 28, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented May 27, 2024 •
edited
Loading

Describe your changes:

Before: minor alignment issue in SEVERITY, and no bottom space
image

After:
image

Before:
image

After:
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues e2e:Observability safe to test Add this label to run secure Github workflows on PRs and removed UI UI specific issues labels May 27, 2024
@cypress Cypress
Copy link

cypress bot commented May 27, 2024 •
edited
Loading

Passing run #34271 ↗︎

0 76 0 0 Flakiness 0

Details:

fixed failing unit test
Project: openmetadata Commit: b7c8133aea
Status: Passed Duration: 08:56 💡
Started: May 28, 2024 7:31 AM Ended: May 28, 2024 7:40 AM

Review all test suite changes for PR #16427 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.79% (34796/53706) 41.66% (13718/32931) 43.6% (4268/9788)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 merged commit 0c974ed into main May 28, 2024
14 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the observability-ui-feedback branch May 28, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
e2e:Observability safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaileshParmar11 @chirag-madlani