Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#15336 UI: Add Pagination to Data Quality Tab on Entity pages #15475

Merged
merged 9 commits into from
Mar 8, 2024
Merged

#15336 UI: Add Pagination to Data Quality Tab on Entity pages #15475

merged 9 commits into from
Mar 8, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Mar 6, 2024 •
edited
Loading

Describe your changes:

Fixes #15336

  • Added pagination to data quality tab (entity detail page)
  • Removed Test count and test status column from column profiler table
  • Added api call based count on the column details page
  • Cleanup the unnecessary code.
  • Added unit test for pagination
  • Filter and pagination
Screen.Recording.2024-03-08.at.4.05.27.PM.mov
  • Removed test case count and status column
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added e2e:DataAssets UI UI specific issues labels Mar 6, 2024
@ShaileshParmar11 ShaileshParmar11 marked this pull request as draft March 6, 2024 16:09
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.33% (32441/51229) 40.95% (12632/30845) 41.95% (3957/9433)

@ShaileshParmar11 ShaileshParmar11 self-assigned this Mar 8, 2024
@ShaileshParmar11 ShaileshParmar11 marked this pull request as ready for review March 8, 2024 10:38
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Mar 8, 2024

Passing run #33367 ↗︎

0 269 6 0 Flakiness 0

Details:

Merge branch 'main' into issue-15336
Project: openmetadata Commit: 35ad9a179b
Status: Passed Duration: 28:13 💡
Started: Mar 8, 2024 10:57 AM Ended: Mar 8, 2024 11:25 AM

Review all test suite changes for PR #15475 ↗︎

@chirag-madlani chirag-madlani merged commit 226db58 into main Mar 8, 2024
19 checks passed
@chirag-madlani chirag-madlani deleted the issue-15336 branch March 8, 2024 12:01
ShaileshParmar11 added a commit that referenced this pull request Mar 20, 2024
@ShaileshParmar11
#15336 UI: Add Pagination to Data Quality Tab on Entity pages (#15475)
6a59158 
* #15336 UI: Add Pagination to Data Quality Tab on Entity pages

* fixed failing unit test

* removed test case count and test case status column from column profiler table and added fetch call in column details page

* added unit test for pagination

* removed loading test as it was written for dataQualityTab component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Pagination to Data Quality Tab on Entity pages
2 participants
@ShaileshParmar11 @chirag-madlani