-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR - Reconfigure app metrics #15460
Conversation
@@ -263,7 +263,7 @@ eventMonitoringConfiguration: | |||
eventMonitor: ${EVENT_MONITOR:-prometheus} # Possible values are "prometheus", "cloudwatch" | |||
batchSize: ${EVENT_MONITOR_BATCH_SIZE:-10} | |||
pathPattern: ${EVENT_MONITOR_PATH_PATTERN:-["/api/v1/tables/*", "/api/v1/health-check"]} | |||
latency: ${EVENT_MONITOR_LATENCY:-[]} # For value p99=0.99, p90=0.90, p50=0.50 etc. | |||
latency: ${EVENT_MONITOR_LATENCY:-[0.99, 0.90]} # For value p99=0.99, p90=0.90, p50=0.50 etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keeping these defaults here. Seem like sensible values
Timer.builder("latency_requests") | ||
.description("Request latency in seconds.") | ||
private static final double[] latencyBuckets = new double[] | ||
{.01, .1, 1, 2, 5, 10, 20, 60, 300}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LMK if you see the need on having these as a config cc @tutte
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Static is ok, we can remove the 300 as the HTTP should kill every request beyond 60s
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
|
* MINOR - Reconfigure app metrics * Format
Describe your changes:
Rel to https://github.com/open-metadata/openmetadata-collate/issues/355
jvm_*
metricslatency
histogram, and just keeping percentileshttp_server_requests
histogram. Now we only haveI worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>