Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: make test setup non-static so it can be overriden #15451

Merged
merged 7 commits into from
Mar 6, 2024
Merged

MINOR: make test setup non-static so it can be overriden #15451

merged 7 commits into from
Mar 6, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Mar 5, 2024

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

sushi30 added 2 commits March 4, 2024 15:22
@sushi30
changes to support ui - not working for now
206d92f
@sushi30
test
8668b41 
- made test hooks non-static
- added getApp
@sushi30 sushi30 requested a review from a team as a code owner March 5, 2024 06:43
@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Mar 5, 2024
@cypress Cypress
Copy link

cypress bot commented Mar 5, 2024 •
edited
Loading

176 failed tests on run #33341 ↗︎

176 555 12 3 Flakiness 0

Details:

format
Project: openmetadata Commit: 973ac19fc5
Status: Failed Duration: 46:52 💡
Started: Mar 6, 2024 9:00 AM Ended: Mar 6, 2024 10:47 AM
Failed  Pages/Entity.spec.ts • 21 failed tests • cypress-ci-mysql-pr-8169182524-1

View Output Video

Test Artifacts
Entity detail page > Dashboard page > User as Owner assign, update & delete Screenshots Video
Entity detail page > Dashboard page > Team as Owner assign, update & delete Screenshots Video
Entity detail page > Dashboard page > Tags assign, update & delete Screenshots Video
Entity detail page > Pipeline page > User as Owner assign, update & delete Screenshots Video
Entity detail page > Pipeline page > Team as Owner assign, update & delete Screenshots Video
Entity detail page > Pipeline page > Tags assign, update & delete Screenshots Video
Entity detail page > Topic page > User as Owner assign, update & delete Screenshots Video
Entity detail page > Topic page > Team as Owner assign, update & delete Screenshots Video
Entity detail page > Topic page > Tags assign, update & delete Screenshots Video
Entity detail page > MlModel page > User as Owner assign, update & delete Screenshots Video
The first 10 failed tests are shown, see all 21 tests in Cypress Cloud.
Failed  Service/ServiceIngestion.spec.ts • 3 failed tests • cypress-ci-mysql-pr-8169182524-1

View Output Video

Test Artifacts
Superset Ingestion > Create & Ingest Superset service Screenshots Video
Superset Ingestion > Update schedule options and verify Screenshots Video
Superset Ingestion > Delete Superset service Screenshots Video
Failed  Pages/Services.spec.ts • 21 failed tests • cypress-ci-mysql-pr-8169182524-1

View Output Video

Test Artifacts
Services detail page > Database Service page > User as Owner assign, update & delete Screenshots Video
Services detail page > Database Service page > Team as Owner assign, update & delete Screenshots Video
Services detail page > Database Service page > Tags assign, update & delete Screenshots Video
Services detail page > Messaging Service page > User as Owner assign, update & delete Screenshots Video
Services detail page > Messaging Service page > Team as Owner assign, update & delete Screenshots Video
Services detail page > Messaging Service page > Tags assign, update & delete Screenshots Video
Services detail page > Dashboard Service page > User as Owner assign, update & delete Screenshots Video
Services detail page > Dashboard Service page > Team as Owner assign, update & delete Screenshots Video
Services detail page > Dashboard Service page > Tags assign, update & delete Screenshots Video
Services detail page > Pipeline Service page > User as Owner assign, update & delete Screenshots Video
The first 10 failed tests are shown, see all 21 tests in Cypress Cloud.
Failed  Pages/Database.spec.ts • 12 failed tests • cypress-ci-mysql-pr-8169182524-1

View Output Video

Test Artifacts
Database hierarchy details page > Database page > User as Owner assign, update & delete Screenshots Video
Database hierarchy details page > Database page > Team as Owner assign, update & delete Screenshots Video
Database hierarchy details page > Database page > Tags assign, update & delete Screenshots Video
Database hierarchy details page > Database Schema page > User as Owner assign, update & delete Screenshots Video
Database hierarchy details page > Database Schema page > Team as Owner assign, update & delete Screenshots Video
Database hierarchy details page > Database Schema page > Tags assign, update & delete Screenshots Video
Database hierarchy details page > Table page > User as Owner assign, update & delete Screenshots Video
Database hierarchy details page > Table page > Team as Owner assign, update & delete Screenshots Video
Database hierarchy details page > Table page > Tags assign, update & delete Screenshots Video
Database hierarchy details page > Store Procedure page > User as Owner assign, update & delete Screenshots Video
The first 10 failed tests are shown, see all 12 tests in Cypress Cloud.
Failed  Flow/SearchFlow.spec.js • 7 failed tests • cypress-ci-mysql-pr-8169182524-1

View Output Video

Test Artifacts
Advance search > Single filed search > Verify advance search results for Service field and all condition Screenshots Video
Advance search > Single filed search > Verify advance search results for Database field and all condition Screenshots Video
Advance search > Single filed search > Verify advance search results for Database Schema field and all condition Screenshots Video
Advance search > Group search > Verify Add group functionality for All with AND operator & condition == and != Screenshots Video
Advance search > Group search > Verify Add group functionality for All with AND operator & condition Any in and Not in Screenshots Video
Advance search > Group search > Verify Add group functionality for All with OR operator & condition == and != Screenshots Video
Advance search > Group search > Verify Add group functionality for All with OR operator & condition Any in and Not in Screenshots Video

The first 5 failed specs are shown, see all 31 specs in Cypress Cloud.

Review all test suite changes for PR #15451 ↗︎

@sushi30 sushi30 changed the title Test changes MINOR: make test setup non-static so it can be overriden Mar 5, 2024
mohityadav766
mohityadav766 previously approved these changes Mar 5, 2024
View reviewed changes
@sushi30
Revert "configuration"
6afa319 
This reverts commit ed2e675.
@sushi30 sushi30 requested a review from mohityadav766 March 6, 2024 08:23
mohityadav766
mohityadav766 previously approved these changes Mar 6, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sushi30 sushi30 requested a review from mohityadav766 March 6, 2024 09:50
@sushi30 sushi30 enabled auto-merge (squash) March 6, 2024 13:04
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sushi30 sushi30 merged commit 182f3a3 into main Mar 6, 2024
13 of 16 checks passed
@sushi30 sushi30 deleted the test-changes branch March 6, 2024 14:14
mohityadav766 pushed a commit that referenced this pull request Mar 22, 2024
@sushi30 @mohityadav766
MINOR: make test setup non-static so it can be overriden (#15451)
f723a27 
- made test hooks non-static
- added getApp
---------

Co-authored-by: Mohit Yadav <[email protected]>
(cherry picked from commit 182f3a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

Assignees
No one assigned
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sushi30 @mohityadav766